| Summary: | Review Request: rubygem-gtksourceview2 - Ruby binding of gtksourceview-2.x | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-21 17:27:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mamoru TASAKA
2011-02-18 20:47:00 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-gtksourceview2/rubygem-gtksourceview2-0.90.8-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-gtksourceview2/rubygem-gtksourceview2.spec * Thu Mar 10 2011 Mamoru Tasaka <mtasaka> - 0.90.8-1 - 0.90.8 I am taking this review. * gtk2 dependency
- Upstream specifies gtk2 >= 0.90.8 runtime dependency while you allow
dependency on 0.90.7. I just want to ensure that this is intentional,
not by mistake.
* rpmlint output:
- rubygem-gtksourceview2.spec:116: W: mixed-use-of-spaces-and-tabs
(spaces: line 116, tab: line 1)
- rubygem-gtksourceview2.src: W: strange-permission
gtksourceview2-0.90.8.gem 0600L
Otherwise I have no objections. So this package is APPROVED.
Thank you. I will address your comments. New Package SCM Request ======================= Package Name: rubygem-gtksourceview2 Short Description: Ruby binding of gtksourceview-2.x Owners: mtasaka Branches: f15 f14 Git done (by process-git-requests). Built, push request submitted. Thank you for the review and git procedure, closing. |