Bug 679009
Summary: | noSSLServerURL is not updated after rhel3/4 kickstarts from RHN Satellite v540 | ||
---|---|---|---|
Product: | Red Hat Satellite 5 | Reporter: | Paresh Mutha <pmutha> |
Component: | Provisioning | Assignee: | Jan Pazdziora (Red Hat) <jpazdziora> |
Status: | CLOSED ERRATA | QA Contact: | Martin Minar <mminar> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 540 | CC: | cperry, fdewaley, jhutar, jpazdziora, mkoci, mminar, mzazrivec, prc |
Target Milestone: | --- | Keywords: | Patch, Regression |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | spacewalk-java-1.2.39-58 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-06-17 02:29:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 703064 | ||
Bug Blocks: | 677501 |
Description
Paresh Mutha
2011-02-21 09:37:44 UTC
Taking. The problem was introduced by the fix for bug 576211. Paresh, my proposed patch would be: --- a/java/code/src/com/redhat/rhn/manager/kickstart/KickstartFormatter.java +++ b/java/code/src/com/redhat/rhn/manager/kickstart/KickstartFormatter.java @@ -639,12 +639,12 @@ public class KickstartFormatter { log.debug("adding perl -npe for /etc/sysconfig/rhn/up2date"); if (this.ksdata.isRhel2()) { - retval.append("perl -npe 's|^(\\s*serverURL\\s*=\\s*[^:]+://)[^/]*/|${1}" + + retval.append("perl -npe 's|^(\\s*(noSSLS|s)erverURL\\s*=\\s*[^:]+://)[^/]*/|${1}" + up2datehost + "/|' -i /etc/sysconfig/rhn/rhn_register" + NEWLINE); } // both rhel 2 and rhel3/4 need the following - retval.append("perl -npe 's|^(\\s*serverURL\\s*=\\s*[^:]+://)[^/]*/|\\${1}" + + retval.append("perl -npe 's|^(\\s*(noSSLS|s)erverURL\\s*=\\s*[^:]+://)[^/]*/|\\${1}" + up2datehost + "/|' -i /etc/sysconfig/rhn/up2date" + NEWLINE); to avoid any more checks for RHEL veersions. Does it sound reasonable? Patch from comment 5 committed to upstream, Spacewalk master, 3241e638f6f406ec6ebfb4e5b30d59a4bdc0a232, to give it some exposure. yes. It looks better than what I proposed and serves the purpose. thnx! Checkstyle fix in Spacewalk master, 34daa81f1bb843a72b18f4b897da4e2f71ae9248. Verified in stage w/ spacewalk-java-1.2.39-82 -> release pending. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. https://rhn.redhat.com/errata/RHSA-2011-0879.html |