Bug 679153

Summary: virt-pki-validate has missing dependency
Product: Red Hat Enterprise Linux 6 Reporter: Eric Blake <eblake>
Component: libvirtAssignee: Eric Blake <eblake>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.1CC: dallan, dyuan, eblake, mjenner, xen-maint, yoyzhang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-0.8.7-8.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:28:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Eric Blake 2011-02-21 18:27:53 UTC
Description of problem:
Two bugs for the price of one BZ :)
libvirt-client ships the virt-pki-validate script, but this script is useless if certtool is not available.  Then the script has improper shell quoting, rendering its output message worthless.

Version-Release number of selected component (if applicable):
libvirt-client-0.8.7-7.el6

How reproducible:
100%

Steps to Reproduce:
1. On a fresh machine, install libvirt-client.
2. Run virt-pki-validate
  
Actual results:
1. gnutls-utils is not installed, so certtool is missing
2. the script reports "Found ", instead of the intended fall-back error message:
    echo "Could not locate the certtool program"
    echo "make sure the gnutls-utils (or gnutls-bin) package is installed"
 
Expected results:
1. gnutls-utils should be installed
2. the script's first output line should be "Found /usr/bin/certtool"

Additional info:
Fixed by two upstream patches:
https://www.redhat.com/archives/libvir-list/2011-February/msg00812.html
https://www.redhat.com/archives/libvir-list/2011-February/msg00910.html

Comment 3 dyuan 2011-02-25 03:39:31 UTC
Verified this bug passed with libvirt-0.8.7-8.el6.

# rpm -Uvh libvirt-client-0.8.7-8.el6.x86_64.rpm 
error: Failed dependencies:
	gnutls-utils is needed by libvirt-client-0.8.7-8.el6.x86_64

# yum -y install libvirt-client-0.8.7-8.el6.x86_64.rpm 
Loaded plugins: refresh-packagekit, rhnplugin
Setting up Install Process
Examining libvirt-client-0.8.7-8.el6.x86_64.rpm: libvirt-client-0.8.7-8.el6.x86_64
Marking libvirt-client-0.8.7-8.el6.x86_64.rpm as an update to libvirt-client-0.8.7-7.el6.x86_64
Resolving Dependencies
--> Running transaction check
--> Processing Dependency: libvirt-client = 0.8.7-7.el6 for package: libvirt-python-0.8.7-7.el6.x86_64
--> Processing Dependency: libvirt-client = 0.8.7-7.el6 for package: libvirt-0.8.7-7.el6.x86_64
---> Package libvirt-client.x86_64 0:0.8.7-8.el6 set to be updated
--> Processing Dependency: gnutls-utils for package: libvirt-client-0.8.7-8.el6.x86_64
--> Finished Dependency Resolution

# virt-pki-validate 
Found /usr/bin/certtool
the /etc/pki/libvirt directory is missing, it is usually
installed by the libvirt package
as root do: mkdir -m 755 /etc/pki/libvirt ; chown root:root /etc/pki/libvirt

Comment 6 errata-xmlrpc 2011-05-19 13:28:06 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0596.html