Bug 679424

Description of problem:multiple "unexpected operator" errors at boot. in my case it still boots.


Version-Release number of selected component (if applicable):


How reproducible:Every boot


Steps to Reproduce:
1.Upgrade to dracut-008-5.fc15.noarch
2.boot
3.
  
Actual results: multiple "unexpected operator" errors at boot


Expected results: no errors


Additional info:
It's in the lvm_scan.sh

There was another check for "sysinit" which used the maj, min, sub from the lvm version call. I've fixed it locally though it's probably not as elegant as it could have been.



Broken:

check_lvm_ver() {
    maj=$1; shift;
    min=$1; shift;
    ver=$1; shift;
    # --poll is supported since 2.2.57
    [ $1 -lt $maj ] && return 1
    [ $1 -gt $maj ] && return 0
    [ $2 -lt $min ] && return 1
    [ $2 -gt $min ] && return 0
    [ $3 -ge $ver ] && return 0
    return 1
}

lvm version 2>/dev/null | ( \
    IFS=. read maj min sub; 
    maj=${maj##*:}; 
    sub=${sub%% *}; sub=${sub%%\(*}; 
    ) 2>/dev/null

nopoll=$(
    # hopefully this output format will never change, e.g.:
    #   LVM version:     2.02.53(1) (2009-09-25)
        check_lvm_ver 2 2 57 $maj $min $sub && \
            echo " --poll n ";
)

sysinit=$(
    # hopefully this output format will never change, e.g.:
    #   LVM version:     2.02.53(1) (2009-09-25)
        check_lvm_ver 2 2 65 $maj $min $sub && \
            echo " --sysinit ";
)


Fixed:

check_lvm_ver() {
    maj=$1; shift;
    min=$1; shift;
    ver=$1; shift;
    # --poll is supported since 2.2.57
    [ $1 -lt $maj ] && return 1
    [ $1 -gt $maj ] && return 0
    [ $2 -lt $min ] && return 1
    [ $2 -gt $min ] && return 0
    [ $3 -ge $ver ] && return 0
    return 1
}

nopoll=$(
    # hopefully this output format will never change, e.g.:
    #   LVM version:     2.02.53(1) (2009-09-25)
    lvm version 2>/dev/null | ( \
        IFS=. read maj min sub; 
        maj=${maj##*:}; 
        sub=${sub%% *}; sub=${sub%%\(*}; 
        check_lvm_ver 2 2 57 $maj $min $sub && \
            echo " --poll n ";
    ) 2>/dev/null 
)

sysinit=$(
    # hopefully this output format will never change, e.g.:
    #   LVM version:     2.02.53(1) (2009-09-25)
    lvm version 2>/dev/null | ( \
        IFS=. read maj min sub; 
        maj=${maj##*:}; 
        sub=${sub%% *}; sub=${sub%%\(*}; 
        check_lvm_ver 2 2 65 $maj $min $sub && \
            echo " --sysinit ";
    ) 2>/dev/null 
)