Bug 679512

Summary: Request to remove logging of "Unable to read FCP priority data" from qla2xxx per upstream change
Product: Red Hat Enterprise Linux 5 Reporter: Dwight (Bud) Brown <bubrown>
Component: kernelAssignee: Chad Dupuis (Cavium) <cdupuis>
Status: CLOSED CURRENTRELEASE QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6CC: coughlan, c.wiese, ichute, jentrena, jwest, revers
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-24 01:48:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 668957    

Description Dwight (Bud) Brown 2011-02-22 19:08:23 UTC
Description of problem:
Customer upgraded to 5.6z and is now getting messages during boot of:

qla2xxx 0000:0e:00.0: Unable to read FCP priority data.
qla2xxx 0000:17:00.0: Unable to read FCP priority data. 

These messages have been removed upstream.


Version-Release number of selected component (if applicable):
2.6.18-238.1.1.el5 
[ 1] RHEL5.6.z: (!)2.6.18-238.4.1.el5 02-Feb-2011
[ 2] RHEL5.6.z: (!)2.6.18-238.1.1.el5 04-Jan-2011  <<<<


How reproducible:
Happens at each boot (qlogic doesn't have FCP prio table/data?)


Steps to Reproduce:
1. reboot
2.
3.
  
Actual results:
messages output

Expected results:
No messages.

Additional info:
Upstream commit

[SCSI] qla2xxx: Appropriately log FCP priority data messages
author	Madhuranath Iyengar <madhuranath.iyengar>
	Fri, 23 Jul 2010 10:28:24 +0000 (15:28 +0500)
committer	James Bottomley <James.Bottomley>
	Wed, 28 Jul 2010 14:06:08 +0000 (09:06 -0500)
commit	2f0f3f4f06f7cfadebf58b70bd9e7f71d8fd96e4
tree	a830ea66f0f4aca7da0e915d30dca8c1be6cfe28	tree
parent	d94d10e7277069801b4e31b40770314a8421f996	commit | diff
[SCSI] qla2xxx: Appropriately log FCP priority data messages

Part of the patch includes the following change, which removes the message completely.

--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -566,11 +566,8 @@ qla2x00_initialize_adapter(scsi_qla_host_t *vha)
                }
        }
 
-       if (IS_QLA24XX_TYPE(ha) || IS_QLA25XX(ha)) {
-               if (qla24xx_read_fcp_prio_cfg(vha))
-                       qla_printk(KERN_ERR, ha,
-                       "Unable to read FCP priority data.\n");
-       }
+       if (IS_QLA24XX_TYPE(ha) || IS_QLA25XX(ha))
+               qla24xx_read_fcp_prio_cfg(vha);
 
        return (rval);
 }

Comment 3 Chad Dupuis (Cavium) 2011-08-09 12:16:09 UTC
That upstream commit was actually backported to RHEL 5.7 so it could be a candidate to for RHEL 5.6.z.

Comment 4 Chad Dupuis (Cavium) 2011-10-10 13:06:56 UTC
Since this is fixed in RHEL 5.7, can this be closed?