Bug 679692

Summary:	don't compute checksums of unsigned files which are not going to be uploaded
Product:	[Retired] Pulp	Reporter:	Daniel Mach <dmach>
Component:	z_other	Assignee:	Pradeep Kilambi <pkilambi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	Keywords:	Triaged
Target Milestone:	---
Target Release:	Sprint 21
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-08-16 12:06:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	563609, 647488

Description Daniel Mach 2011-02-23 08:57:01 UTC

$ pulp-admin content upload <unsigned-rpm>
* Starting Package Upload operation. See /var/log/pulp/client.log for more verbose output

* Performing Package Uploads to Pulp server

* Content Upload complete.


package is not uploaded and /var/log/pulp/client.log contains:
2011-02-23 09:51:03,533 [ERROR][MainThread] @ content.py:95 - Package [<rpm>] is not signed. Please use --nosig. Skipping 

This takes about 15 seconds for a 600M RPM.
It could fail instantly by detecting if package is unsigned - before checksum is computed.

Comment 1 Pradeep Kilambi 2011-02-23 15:04:12 UTC

fixed! We now check the signature before computing the metadata. Should be in next build.

Comment 2 Jeff Ortel 2011-02-23 17:59:59 UTC

Build: 0.141

Comment 3 Preethi Thomas 2011-03-02 19:41:37 UTC

verified
[root@preethi upload]# rpm -q pulp
pulp-0.0.143-1.fc14.noarch

[root@preethi upload]# pulp-admin content upload /root/upload/grinder-0.0.81-1.fc14.noarch.rpm 
* Starting Package Upload operation. See /var/log/pulp/client.log for more verbose output

* Performing Package Uploads to Pulp server

* Content Upload complete.

2011-03-02 14:47:18,435 [ERROR][MainThread] run() @ content.py:87 - Package [/root/upload/grinder-0.0.81-1.fc14.noarch.rpm] is not signed. Please use --nosig. Skipping

Comment 4 Preethi Thomas 2011-08-16 12:06:49 UTC

Closing with Community Release 15

pulp-0.0.223-4.

Comment 5 Preethi Thomas 2011-08-16 12:20:46 UTC

Closing with Community Release 15

pulp-0.0.223-4.