Bug 679714

+++ This bug was initially created as a clone of Bug #679557 +++

Description of problem:

When using package provided in Satellite 5.4 PyPAM-0.5.0-3el5sat and registering clients using users stored in Active Directory (Samba + Winbind), httpd process dies with a segfault error. 

[Tue Jan 11 13:15:08 2011] [notice] child pid 25658 exit signal Segmentation fault (11)
[Tue Jan 11 13:15:13 2011] [notice] child pid 28084 exit signal Segmentation fault (11)
[Tue Jan 11 13:15:19 2011] [notice] child pid 27209 exit signal Segmentation fault (11)
[Tue Jan 11 13:15:24 2011] [notice] child pid 27213 exit signal Segmentation fault (11)
Tue Jan 11 13:15:30 2011] [notice] child pid 27210 exit signal Segmentation fault (11)

Analysing the core file, we can observe the follow error: 


Program terminated with signal 11, Segmentation fault.
#0  0x00002b13bbbb488e in free () from /lib64/libc.so.6
(gdb) bt
#0  0x00002b13bbbb488e in free () from /lib64/libc.so.6
#1  0x00002b13d6bacdf0 in PyPAM_conv (num_msg=1, msg=0x7fff66806ef0, resp=0x7fff66806f10, appdata_ptr=0x2b13d6b0e330) at PAMmodule.c:59
#2  0x00002b13d73e3863 in ?? () from /lib64/security/pam_winbind.so
#3  0x00002b13d73e438d in ?? () from /lib64/security/pam_winbind.so
#4  0x00002b13d73e693c in pam_sm_authenticate () from /lib64/security/pam_winbind.so
#5  0x00002b13d6dbddc7 in _pam_dispatch () from /lib64/libpam.so.0
#6  0x00002b13d6dbd6d2 in pam_authenticate () from /lib64/libpam.so.0
#7  0x00002b13d6bad2d7 in PyPAM_authenticate (self=0x2b13d6b0e330, args=<value optimized out>) at PAMmodule.c:215


--- Additional comment from tmraz on 2011-02-23 05:05:46 EST ---

Created attachment 480399 [details]
Correct patch with proper deallocation in the error condition

Please test with this patch. Although to test the deallocation an error in the conversation function in the response must be done.