Bug 680020

Hi Brendan,

here are some initial notes on your package:

- the package doesn't build in mock due to a missing BR: python-lxml

- The license file must only be added if it's part of the source tarball. Since
  it's currently not present there, please drop it from the spec, and ask 
  upstream to add it to the archive.
  (https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text)

- move the for loop to the %prep section

- If you plan to maintain the package for EPEL < 6 too, add a %clean section.
  Otherwise, you can drop all the buildroot stuff.

- please be a bit more verbose in %files to avoid accidentally putting unwanted
  files into the package:
  %{python_sitelib}/pyquery/
  %{python_sitelib}/pyquery*.egg-info/

Thanks Martin,

changes have been made as directed and reposted here:

SPEC: http://bsjones.fedorapeople.org/python-pyquery.spec
SRPM: http://bsjones.fedorapeople.org/python-pyquery-0.6.1-2.fc14.src.rpm

rpmlint /var/lib/mock/fedora-14-i386/result/python-pyquery-0.6.1-2.fc14.noarch.rpm
python-pyquery.noarch: W: spelling-error Summary(en_US) jquery -> query, j query, equerry
python-pyquery.noarch: W: spelling-error %description -l en_US jquery -> query, j query, equerry
python-pyquery.noarch: W: spelling-error %description -l en_US lxml -> lx ml, lx-ml, lxvi
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

rpmlint /var/lib/mock/fedora-14-i386/result/python-pyquery-0.6.1-2.fc14.src.rpm 
python-pyquery.src: W: spelling-error Summary(en_US) jquery -> query, j query, equerry
python-pyquery.src: W: spelling-error %description -l en_US jquery -> query, j query, equerry
python-pyquery.src: W: spelling-error %description -l en_US lxml -> lx ml, lx-ml, lxvi
1 packages and 0 specfiles checked; 0 errors, 3 warnings.




-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Hi Brendan,

the package looks good now. Please also drop the BuildRoot field as it's not required in Fedora any longer. I also suggest to replace "jquery" with "jQuery" in the Summary and the %description because it's the spelling used by the upstream project. Both issues are no blockers, though.

The next step is to request a Git repository with the distro branches you're
planning to maintain. See the following wiki page for further information:
https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure


$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
python-pyquery.noarch: W: spelling-error Summary(en_US) jquery -> query, j query, equerry
python-pyquery.noarch: W: spelling-error %description -l en_US jquery -> query, j query, equerry
python-pyquery.noarch: W: spelling-error %description -l en_US lxml -> lx ml, lx-ml, lxvi
python-pyquery.src: W: spelling-error Summary(en_US) jquery -> query, j query, equerry
python-pyquery.src: W: spelling-error %description -l en_US jquery -> query, j query, equerry
python-pyquery.src: W: spelling-error %description -l en_US lxml -> lx ml, lx-ml, lxvi
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - BSD according to source file headers

[+] MUST: The License field in the package spec file must match the actual license.
[.] MUST: The file containing the text of the license(s) for the package must be included in %doc.
    - no license file present

[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum pyquery-0.6.1.tar.gz*
    2a677d7c52b1aa89f5aaa70427e36b70  pyquery-0.6.1.tar.gz
    2a677d7c52b1aa89f5aaa70427e36b70  pyquery-0.6.1.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file
[+] MUST: Packages must not own files or directories already owned by other packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] MUST: Python eggs must be built from source. They cannot simply drop an egg from upstream into the proper directory.
[+] MUST: Python eggs must not download any dependencies during the build process.
[+] MUST: If egg-info files are generated by the modules build scripts they must be included in the package.
[.] MUST: When building a compat package, it must install using easy_install -m so it won't conflict with the main package.
[.] MUST: When building multiple versions (for a compat package) one of the packages must contain a default version that is usable via "import MODULE" with no prior setup.
[.] SHOULD: A package which is used by another package via an egg interface should provide egg info. 

[X] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[.] SHOULD: Your package should contain man pages for binaries/scripts.

----------------
Package APPROVED
----------------

Thanks Martin for doing this so quickly!

I have updated SPEC and SRPM with you changes just for completeness:

SPEC: http://bsjones.fedorapeople.org/python-pyquery.spec
SRPM: http://bsjones.fedorapeople.org/python-pyquery-0.6.1-3.fc14.src.rpm





-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

New Package SCM Request
=======================
Package Name: python-pyquery
Short Description: A jQuery-like library for python
Owners: bsjones
Branches: f13 f14 f15
InitialCC:

Git done (by process-git-requests).

Package python-pyquery-0.6.1-3.fc15:
* should fix your issue,
* was pushed to the Fedora 15 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-pyquery-0.6.1-3.fc15'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/python-pyquery-0.6.1-3.fc15
then log in and leave karma (feedback).

Package python-pyquery-0.6.1-3.fc13:
* should fix your issue,
* was pushed to the Fedora 13 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-pyquery-0.6.1-3.fc13'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/python-pyquery-0.6.1-3.fc13
then log in and leave karma (feedback).

python-pyquery-0.6.1-3.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-pyquery'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-pyquery-0.6.1-3.fc13

python-pyquery-0.6.1-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

python-pyquery-0.6.1-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.