Bug 680473

Summary: Review Request: ghc-ForSyDe - Formal System Design methodology
Product: [Fedora] Fedora Reporter: Shakthi Kannan <shakthimaan>
Component: Package ReviewAssignee: Narasimhan <lakshminaras2002>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, haskell-devel, lakshminaras2002, notting
Target Milestone: ---Flags: lakshminaras2002: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ghc-ForSyDe-3.1.1-4.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-13 04:42:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Shakthi Kannan 2011-02-25 17:03:50 UTC
Spec URL: http://shakthimaan.fedorapeople.org/SPECS/ghc-ForSyDe.spec
SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/ghc-ForSyDe-3.1.1-1.fc14.src.rpm
Description: A Formal System Design methodology package

Comment 1 Shakthi Kannan 2011-02-25 17:08:28 UTC
Output of rpmlint:

$  rpmlint ghc-ForSyDe.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$  rpmlint ghc-ForSyDe-3.1.1-1.fc14.src.rpm 
ghc-ForSyDe.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$  rpmlint ghc-ForSyDe-3.1.1-1.fc14.i686.rpm 
ghc-ForSyDe.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$  rpmlint ghc-ForSyDe-devel-3.1.1-1.fc14.i686.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$  rpmlint ghc-ForSyDe-prof-3.1.1-1.fc14.i686.rpm 
ghc-ForSyDe-prof.i686: E: devel-dependency ghc-ForSyDe-devel
ghc-ForSyDe-prof.i686: W: no-documentation
ghc-ForSyDe-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/ForSyDe-3.1.1/libHSForSyDe-3.1.1_p.a
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Successful Koji build for F-14:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2866759

Comment 2 Narasimhan 2011-02-27 06:16:27 UTC
[+]MUST: rpmlint must be run on every package. The output should be posted in the review.

rpmlint -i  *.rpm *.spec
ghc-ForSyDe.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.

ghc-ForSyDe.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.

ghc-ForSyDe-prof.i686: E: devel-dependency ghc-ForSyDe-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

ghc-ForSyDe-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ghc-ForSyDe-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/ForSyDe-3.1.1/libHSForSyDe-3.1.1_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

4 packages and 1 specfiles checked; 1 errors, 4 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Buildroot is ignored - OK
        %clean is ignored - OK
        Build Requires list - NOT OK, missed ghc-mtl
        Summary and description - OK
        API documentation - OK

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
Licensed with BSD license.
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
Yes. The license text is present in LICENSE file.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.

md5sum ghc-ForSyDe-3.1.1-1.fc14.src/ForSyDe-3.1.1.tar.gz 
d215f444893538842cc30c68601036cb  ghc-ForSyDe-3.1.1-1.fc14.src/ForSyDe-3.1.1.tar.gz

md5sum ~/Downloads/ForSyDe-3.1.1.tar.gz 
d215f444893538842cc30c68601036cb  ~/Downloads/ForSyDe-3.1.1.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on i686.
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.

[-]MUST: All build dependencies must be listed in BuildRequires.

ghc-mtl is missing.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}

rpm -e ghc-ForSyDe
error: Failed dependencies:
	ghc-ForSyDe = 3.1.1-1.fc14 is needed by (installed) ghc-ForSyDe-devel-3.1.1-1.fc14.i686

rpm -e ghc-ForSyDe-devel
error: Failed dependencies:
	ghc-ForSyDe-devel = 3.1.1-1.fc14 is needed by (installed) ghc-ForSyDe-prof-3.1.1-1.fc14.i686
	
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section
[+]MUST: Packages must not own files or directories already owned by other packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the packages. Installs fine. Loaded ForSyDe.Process into ghci. Works fine
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

cabal2spec-diff is OK.

Overall comments,
1) Should  forsyde.vhd file go with the base package or the devel package? If it goes with the base package, the devel package will get it automatically. My doubt is that whether the code in the .so would need the vhd file.
2) ghc-mtl is also a dependency but pulled in indirectly. But cabal states it as an explicit dep. Please add it to BuildRequires.

Comment 3 Shakthi Kannan 2011-03-01 10:27:09 UTC
Since upstream has used the .vhd in the data-files section, it has been included in the -devel package. Have also asked upstream for clarification, and haven't got a reply yet.

Added ghc-mtl as dependency.

SPEC: http://shakthimaan.fedorapeople.org/SPECS/ghc-ForSyDe.spec
SRPM: http://shakthimaan.fedorapeople.org/SRPMS/ghc-ForSyDe-3.1.1-2.fc14.src.rpm

Successful Koji build for F-14:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2875536

Comment 4 Narasimhan 2011-03-02 01:04:26 UTC
>Added ghc-mtl as dependency.
Thanks, looks fine now

>Since upstream has used the .vhd in the data-files section, it has been
included in the -devel package
The leksah package, which provides a executable binary, also needs some files from the data section

http://narasim.fedorapeople.org/leksah.spec

Comment 6 Narasimhan 2011-03-06 02:14:16 UTC
>Moved forsyde.vhd to the -base package.
Looks fine. Thanks.

APPROVED.

Comment 7 Shakthi Kannan 2011-03-07 03:22:21 UTC
New Package SCM Request
=======================
Package Name: ghc-ForSyDe
Short Description: A formal system design methodology library for Haskell
Owners: shakthimaan
Branches: F-14 F-15
InitialCC: haskell-sig

Comment 8 Jason Tibbitts 2011-03-07 15:27:32 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2011-03-08 06:25:34 UTC
ghc-ForSyDe-3.1.1-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ghc-ForSyDe-3.1.1-3.fc15

Comment 10 Fedora Update System 2011-03-08 06:25:42 UTC
ghc-ForSyDe-3.1.1-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ghc-ForSyDe-3.1.1-3.fc14

Comment 11 Fedora Update System 2011-03-08 20:24:17 UTC
ghc-ForSyDe-3.1.1-3.fc14 has been pushed to the Fedora 14 testing repository.

Comment 12 Fedora Update System 2011-03-13 04:41:56 UTC
ghc-ForSyDe-3.1.1-3.fc15 has been pushed to the Fedora 15 stable repository.

Comment 13 Fedora Update System 2011-03-14 10:30:50 UTC
ghc-ForSyDe-3.1.1-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ghc-ForSyDe-3.1.1-4.fc15

Comment 14 Fedora Update System 2011-03-14 10:30:58 UTC
ghc-ForSyDe-3.1.1-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ghc-ForSyDe-3.1.1-4.fc14

Comment 15 Fedora Update System 2011-03-19 05:51:19 UTC
ghc-ForSyDe-3.1.1-4.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2011-03-23 22:53:28 UTC
ghc-ForSyDe-3.1.1-4.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.