Bug 680781

Summary:	Aborts when SourceURL returns 404
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	rpmlint	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	15	CC:	a.badger, manuel.wolfshant, tcallawa, tmz, ville.skytta
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rpmlint-1.1-3.fc15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-03-09 03:08:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Mamoru TASAKA 2011-02-27 17:44:10 UTC

Description of problem:
On the review request bug 679913, I noticed that rpmlint frequently
aborts when the source URL returns 404, like:

$ rpmlint ./ftop-1.0-2.fc16.src.rpm 
ftop.src: W: invalid-url Source0: http://ftop.googlecode.com/files/ftop-1.0.tar.bz2 HTTP Error 404: Not Found
0 packages and 0 specfiles checked; 0 errors, 1 warnings.
Traceback (most recent call last):
  File "/usr/bin/rpmlint", line 373, in <module>
    main()
  File "/usr/bin/rpmlint", line 168, in main
    runChecks(pkg)
  File "/usr/bin/rpmlint", line 228, in runChecks
    check.check(pkg)
  File "/usr/share/rpmlint/SpecCheck.py", line 142, in check
    self.check_spec(pkg, self._spec_file)
  File "/usr/share/rpmlint/SpecCheck.py", line 545, in check_spec
    clen = info.get("Content-Length")
AttributeError: 'NoneType' object has no attribute 'get'

Version-Release number of selected component (if applicable):
rpmlint-1.1-2.fc15.noarch

How reproducible:
60%, seems to be depending on the condition of remote (googlecode)
host.

Steps to Reproduce:
1. rpmlint ./ftop-1.0-2.fc16.src.rpm , the testcase now preserved
   on :
   http://mtasaka.fedorapeople.org/Bugfix/rpmlint/ftop-1.0-2.fc16.src.rpm
  
Actual results:
See above

Expected results:
rpmlint should not abort even if the source URL returns 404

Comment 1 Ville Skyttä 2011-02-27 18:13:28 UTC

Already fixed in upstream post-1.1 svn:
http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1836

Comment 2 Fedora Update System 2011-03-03 17:22:43 UTC

Package rpmlint-1.1-3.fc15:
* should fix your issue,
* was pushed to the Fedora 15 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing rpmlint-1.1-3.fc15'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/rpmlint-1.1-3.fc15
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2011-03-04 09:58:41 UTC

rpmlint-1.1-3.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rpmlint'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rpmlint-1.1-3.fc15

Comment 4 Fedora Update System 2011-03-09 03:08:52 UTC

rpmlint-1.1-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.