Bug 681000

Summary: consider using hunspell for nano
Product: [Fedora] Fedora Reporter: Oliver Henshaw <oliver.henshaw>
Component: nanoAssignee: Kamil Dudka <kdudka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 15CC: dwmw2, jaswinder, kdudka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nano-2.3.0-1.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-10 03:07:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 680736    

Description Oliver Henshaw 2011-02-28 18:15:06 UTC
Description of problem:

With a kde livecd derived installation, nano cannot spellcheck. This seems to be because it defaults to use aspell, when fedora has tried to converge on hunspell - http://fedoraproject.org/wiki/Releases/FeatureDictionary .


Version-Release number of selected component (if applicable):

nano-2.2.6-3.fc15.x86_64


Steps to Reproduce:
1. Launch 'nano'
2. Type some words or gibberish
3. ^T to spell-check
  
Actual results:

'Spell checking failed. Error invoking "spell"'

Expected results:

Checked spelling


Additional info:

Spellchecking in nano works if I install aspell or configure the speller as "hunspell" in /etc/nanorc, as expected.

Comment 1 Kamil Dudka 2011-02-28 19:26:11 UTC
Thanks for the report.  What should be the proper fix for that?  Should I change the default /etc/nanorc?  How exactly should such a change look like?  Is there hunspell installed by default?

Comment 2 Oliver Henshaw 2011-03-01 15:26:08 UTC
(In reply to comment #1)
> Thanks for the report.  What should be the proper fix for that?  Should I
> change the default /etc/nanorc?  How exactly should such a change look like? 

Changing /etc/nanorc should work - perhaps something like
- # set speller "aspell -x -c"
+ set speller "hunspell"

But perhaps it would be better to change the default in nano itself - what do upstream think of this? If you do end up differing from upstream it's probably better to patch the config than to patch the source.

> Is there hunspell installed by default?
Yes, it should be. It's default in the "base" comps group.

Comment 3 Kamil Dudka 2011-03-01 15:47:29 UTC
(In reply to comment #2)
> Changing /etc/nanorc should work - perhaps something like
> - # set speller "aspell -x -c"
> + set speller "hunspell"
> 
> But perhaps it would be better to change the default in nano itself - what do

We already provide our own /etc/nanorc because of other options, so I'd personally vote for just changing the config file.

> upstream think of this? If you do end up differing from upstream it's probably
> better to patch the config than to patch the source.

I don't think there is a general consensus about a good default since this is pretty distro-specific option.  The comment in nanorc says:

## Use this spelling checker instead of the internal one.  This option
## does not properly have a default value.

Additionally, the upstream mailing list is not much active at the moment.  Some bug fixes are hanging on the list intact, so I would prefer to not burden upstream with this particular change.

Comment 4 Fedora Update System 2011-03-03 11:21:35 UTC
Package nano-2.3.0-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nano-2.3.0-1.fc15'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/nano-2.3.0-1.fc15
then log in and leave karma (feedback).

Comment 5 Kamil Dudka 2011-03-03 11:27:13 UTC
No reboot should be necessary to run the updated nano :-)

Comment 6 Fedora Update System 2011-03-04 10:02:03 UTC
nano-2.3.0-1.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nano'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/nano-2.3.0-1.fc15

Comment 7 Fedora Update System 2011-03-10 03:07:03 UTC
nano-2.3.0-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Oliver Henshaw 2011-03-15 21:48:10 UTC
Just confirmed this works on a recent kde nightly.

Comment 9 Kamil Dudka 2011-03-16 01:05:13 UTC
Thank you for testing it!