Bug 681093

few comments:
Please change license to GPLv3+
Please remove BuildRoor tag (you've removed clean section, so you cannot build for EPEL5 and below) http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Use %find-lang if possible. 



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Thanks for reviewing, I fixed pointed issues. Here is updated spec and srpm url

Spec URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff.spec
SRPM URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff-0.6.5-2.fc14.src.rpm

Created attachment 481530 [details]
modified spec

I have done some changes in original spec file. Go through it and submit a new package.

These changes include those given in comment2 and
* using install-info scriptlet
* adding %doc files
* removing unnecessary -gnulib translation files.
* rpmlint warning fixed for ChangeLog not utf8 file.

Please check the srpm on koji by doing scratch build.

changed status to "Assigned"

(In reply to comment #3)
> Created attachment 481530 [details]
> modified spec
> 
> I have done some changes in original spec file. Go through it and submit a new
> package.
> 
> These changes include those given in comment2 and
> * using install-info scriptlet
> * adding %doc files
> * removing unnecessary -gnulib translation files.
> * rpmlint warning fixed for ChangeLog not utf8 file.
> 
> Please check the srpm on koji by doing scratch build.

Thanks for suggestion, I added modified spec. Here is updated spec and srpm url

Spec URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff.spec
SRPM URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff-0.6.5-3.fc14.src.rpm

f a package contains a GUI application, then it needs to also include a properly installed .desktop file
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

Check here howto handle translation files
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

(In reply to comment #6)
> f a package contains a GUI application, then it needs to also include a
> properly installed .desktop file
> http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

This package does not contain any GUI so no need to follow this.

(In reply to comment #7)
> Check here howto handle translation files
> http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

I don't see %find_lang is going to work here.

(In reply to comment #8)
> (In reply to comment #6)
> > f a package contains a GUI application, then it needs to also include a
> > properly installed .desktop file
> > http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
> 
> This package does not contain any GUI so no need to follow this.
It is given on source main page but when I run it on terminal it doesn't show any GUI.
> 
> (In reply to comment #7)
> > Check here howto handle translation files
> > http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
> 
> I don't see %find_lang is going to work here.
Right, I added it before but it doesn't seem to work.

(In reply to comment #9)
> > (In reply to comment #7)
> > > Check here howto handle translation files
> > > http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
> > 
> > I don't see %find_lang is going to work here.
> Right, I added it before but it doesn't seem to work.

Really? I just tried and it works as usual (Did you surely
add "-f %{name}.lang" on the line of %files ?)

http://koji.fedoraproject.org/scratch/mtasaka/task_2876462/

(In reply to comment #10)
> (In reply to comment #9)
> > > (In reply to comment #7)
> > > > Check here howto handle translation files
> > > > http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
> > > 
> > > I don't see %find_lang is going to work here.
> > Right, I added it before but it doesn't seem to work.
> 
> Really? I just tried and it works as usual (Did you surely
> add "-f %{name}.lang" on the line of %files ?)
> 
> http://koji.fedoraproject.org/scratch/mtasaka/task_2876462/
Sorry, I made a typo mistake (wrote .lany instead of .lang), Thanks for pointing out here is updated spec and srpm url

Spec URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff.spec
SRPM URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff-0.6.5-4.fc14.src.rpm

(In reply to comment #10)
> (In reply to comment #9)
> > > (In reply to comment #7)
> > > > Check here howto handle translation files
> > > > http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
> > > 
> > > I don't see %find_lang is going to work here.
> > Right, I added it before but it doesn't seem to work.
> 
> Really? I just tried and it works as usual (Did you surely
> add "-f %{name}.lang" on the line of %files ?)
> 
> http://koji.fedoraproject.org/scratch/mtasaka/task_2876462/

Argh! you are right. I was using %find_lang after scriptlets and also before that because of 2 different .mo translations I thought direct use of %find_lang with %{name} will not be possible.

koji build->http://koji.fedoraproject.org/koji/taskinfo?taskID=2883340

Suggestions:-
1) You are still using wrong way of writing Changelog. Note you MUST use hyphen between version and release and not a DOT.
Replace
* Tue Mar 1 2011 Praveen Kumar <kumarpraveen.nitdgp> 0.6.5.4
to
* Tue Mar 1 2011 Praveen Kumar <kumarpraveen.nitdgp> 0.6.5-4

2) In Changelog you need to use % character as %% so replace
- Adding %doc files
to
- Adding %%doc files



APPROVED.

Fixed issue, Here is updated spec and srpm url
Spec URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff.spec
SRPM URL: http://kumarpraveen.fedorapeople.org/wdiff/wdiff-0.6.5-5.fc14.src.rpm

New Package SCM Request
=======================
Package Name: wdiff
Short Description: A front-end to GNU diff
Owners: kumarpraveen
Branches: f13 f14 f15

Git done (by process-git-requests).

wdiff-0.6.5-5.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/wdiff-0.6.5-5.fc13

wdiff-0.6.5-5.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/wdiff-0.6.5-5.fc14

wdiff-0.6.5-5.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/wdiff-0.6.5-5.fc15

wdiff-0.6.5-5.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update wdiff'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/wdiff-0.6.5-5.fc15

wdiff-0.6.5-5.fc15 has been pushed to the Fedora 15 stable repository.

wdiff-0.6.5-5.fc13 has been pushed to the Fedora 13 stable repository.

wdiff-0.6.5-5.fc14 has been pushed to the Fedora 14 stable repository.

New Branch SCM Request
=======================
Package Name: wdiff
Short Description: A front-end to GNU diff
Owners: kumarpraveen
Branches: el6, epel7

Many invalid branches requested.

New Package SCM Request
=======================
Package Name: wdiff
Short Description: A front-end to GNU diff
Owners: kumarpraveen
Branches: el6, epel7

Git done (by process-git-requests).

Package Change Request
=======================
Package Name: wdiff
New Branches: el6 epel7
Owners: kumarpraveen

Git done (by process-git-requests).