Bug 681143

Summary:	make bkradd omits requirements/runfor in Makefile that differ in case
Product:	[Retired] Beaker	Reporter:	Miroslav Vadkerti <mvadkert>
Component:	command line	Assignee:	Bill Peck <bpeck>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	0.6	CC:	bpeck, dcallagh, mcsontos, rmancy, stl
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-03-10 05:21:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Miroslav Vadkerti 2011-03-01 09:30:13 UTC

Description of problem:
make bkradd omits requirements/run for in Makefile that differ in case. 

See the differences in Makefile and beaker task below:
http://nest.test.redhat.com/mnt/qa/scratch/mvadkert/cvs/tests/openCryptoki/Sanity/init-scripts-LSB/Makefile
https://beaker.engineering.redhat.com/tasks/1802

The package opencryptoki is not added to the requirements and run for fields! Please note that opencryptoki is a RHEL6 only package and openCryptoki is <= RHEL5 package.


Version-Release number of selected component (if applicable):
beaker-0.6.2-1.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. make bkradd in the test
2. Check the task
  
Actual results:
No all packages added

Expected results:
All packages added

Additional info:

Comment 1 Marian Csontos 2011-03-01 09:42:31 UTC

I am not sure it's supposed to.

Workaround: use both of them. The one which does not exist will be ignored.

Comment 2 Miroslav Vadkerti 2011-03-01 09:52:41 UTC

In Makefile I have specified both of them, but the latter doesn't get installed on the machine.

Comment 3 Miroslav Vadkerti 2011-03-01 09:53:26 UTC

I don't understand the workaround :)

Comment 4 Miroslav Vadkerti 2011-03-01 09:57:13 UTC

I also tried to put the requirements in one line and it didn't help

Comment 5 Miroslav Vadkerti 2011-03-01 10:01:08 UTC

As the test in description should be run only for EL6 I will change it to only opencryptoki.

Here is an example of task which should be run for both:
https://beaker.engineering.redhat.com/tasks/1803
vs
http://nest.test.redhat.com/mnt/qa/scratch/mvadkert/cvs/tests/openCryptoki/Sanity/testsuite/Makefile

Comment 6 Miroslav Vadkerti 2011-03-01 10:05:11 UTC

IMPORTANT NOTE:
The example from the description is not actual anymore, please see the the example in comment #5 instead!

Comment 7 Marian Csontos 2011-03-01 10:06:10 UTC

Clarified by IM: wrong understanding of the text on my side...

The task was built and tagged properly. It's just the requirements do not propagate to beaker correctly.

Looks like case-insensitive comparison is used where it should not.

Could you try if the same happens for a new task?

Comment 8 Miroslav Vadkerti 2011-03-01 10:22:50 UTC

The same happens for a new task:
https://beaker.engineering.redhat.com/tasks/5539

Comment 9 Bill Peck 2011-03-01 14:18:37 UTC

Looks like the query to the db is not case sensitive by default.