Bug 681219

Summary: linuxrc.s390 show_parms does not write valid syntax
Product: Red Hat Enterprise Linux 5 Reporter: Philip Rowlands <phr>
Component: anacondaAssignee: David Cantrell <dcantrell>
Status: CLOSED ERRATA QA Contact: Release Test Team <release-test-team>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6CC: atodorov, brueckner, jstodola
Target Milestone: rc   
Target Release: ---   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: anaconda-11.1.2.243-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 689470 729691 772970 (view as bug list) Environment:
Last Closed: 2012-02-21 05:37:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 726828, 772970    

Description Philip Rowlands 2011-03-01 13:43:52 UTC
In loader2/linuxrc.s390:show_parms

the script writes out an example CMSCONFFILE to the console. However, in certain circumstances the syntax is invalid, for example
DASD=777,888(ro)

This causes bash to emit an error
line 10: syntax error near unexpected token `('

Suggested fix is to single-quote the output in show_parms() to avoid issues with shell syntax, e.g.
DASD='777,888(ro)'

I haven't checked all the other parameters, and in some cases the valid arguments will not need quoting, LAYER2=1 for example, but for consistency quoting throughout the file is preferred.

Further, the RHEL Installation Guide ought to warn about this; RHEL6 I.G. Ed 1.0 s 26.3 gives a DASD= example which will not work due to this issue.

Comment 1 RHEL Program Management 2011-08-05 12:31:09 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 2 Alexander Todorov 2011-08-10 10:37:33 UTC
(In reply to comment #0)
> 
> Further, the RHEL Installation Guide ought to warn about this; RHEL6 I.G. Ed
> 1.0 s 26.3 gives a DASD= example which will not work due to this issue.

Installation guide is a separate component. Please file a separate bug for it.

Comment 3 Philip Rowlands 2011-08-10 14:51:35 UTC
Filed separate Installation Guide bug 729691.

Comment 5 Jan Stodola 2012-01-10 14:48:57 UTC
CMS configuration values printed by linuxrc are single-quoted in RHEL-5.8 Snapshot 3 (anaconda-11.1.2.250-1.s390x).

Moving to VERIFIED.

Comment 6 errata-xmlrpc 2012-02-21 05:37:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0197.html