Bug 681280

Summary: [vdsm] when qemu process dies during migration vdsm reports the vm status as up*(not-responding)
Product: Red Hat Enterprise Linux 6 Reporter: David Naori <dnaori>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED CURRENTRELEASE QA Contact: yeylon <yeylon>
Severity: low Docs Contact:
Priority: medium    
Version: 6.1CC: abaron, bazulay, danken, dnaori, hateya, iheim, ilvovsky, mgoldboi, srevivo, ykaul
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vdsm-4.9-52.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-19 15:12:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
full vdsm log none

Description David Naori 2011-03-01 16:30:58 UTC
Created attachment 481676 [details]
full vdsm log

Description of problem: 
when migrating multiple vms and qemu process dies on the source- vdsm reports the vm status as up*(not-responding) while he is actually down.

Version-Release number of selected component (if applicable):

libvirt-0.8.7-8
vdsm-4.9-51

How reproducible:
always


Steps to Reproduce:
1.migrate 5 vms, 
2.when migration start kill qemu prosess in the source
  
full vdsm log attached.

Comment 2 Dan Kenigsberg 2011-03-02 07:53:57 UTC
Did my patch solve the problem?

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 24ea8a7..a864f69 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -337,7 +337,7 @@ class MigrationSourceThread(threading.Thread):
         if self._mode == 'file' or self._method != 'online':
             self._vm.cont()
         # either way, migration has finished
-        self._vm._lastStatus = 'Up'
+        self._vm.lastStatus = 'Up'
 
     def _waitForOutgoingMigration(self):
         now = time.time()

Comment 3 David Naori 2011-03-02 08:24:19 UTC
I have tested your patch and it works.

Comment 4 David Naori 2011-03-08 13:54:27 UTC
Verified on vdsm-4.9-52.el6