Bug 681393
| Summary: | Review Request: perl-Nagios-Plugin-WWW-Mechanize - Login to a web page as a user and get data as a Nagios plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ken Dreyer <ktdreyer> |
| Component: | Package Review | Assignee: | Steve Traylen <steve.traylen> |
| Status: | CLOSED ERRATA | QA Contact: | Steve Traylen <steve.traylen> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, notting, steve.traylen |
| Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-21 03:32:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ken Dreyer
2011-03-02 01:16:28 UTC
Koji scratch build for F15 is actually http://koji.fedoraproject.org/koji/taskinfo?taskID=2877487 The requisite perl-WWW-Mechanize is in EPEL 6, so I have updated my package to build there. Updated -2 release: http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize.spec http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize-0.13-2.el6.src.rpm Koji scratch build: EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879094 F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879105 F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879107 F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879109
- Package meets naming and packaging guidelines
It does.
- Spec file matches base package name.
Yes.
- Spec has consistant macro usage.
Yes.
- Meets Packaging Guidelines.
Yes
- License
GPL+ or Artistic
- License field in spec matches
It does.
- License file included in package
It does
- Spec in American English
Yes.
- Spec is legible.
Yes.
- Sources match upstream md5sum:
$ md5sum Nagios-Plugin-WWW-Mechanize-0.13.tar.gz ../SOURCES/Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
8cfc2c93d84a88756666c3d7a6baf69e Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
8cfc2c93d84a88756666c3d7a6baf69e ../SOURCES/Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
- BuildRequires correct
Yes
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Package is code or permissible content.
- Doc subpackage needed/used
Not needed.
- Packages %doc files don't affect runtime.
The don't
- Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
- No rpmlint output.
rpmint is clean as above.
- final provides and requires are sane:
COMMENT , a few double requires that could be cleaned up.
SHOULD Items:
- Should build in mock.
Yes
- Should build on all supported archs
Yes
- Should function as described.
The checks work at lease.
- Should have dist tag
Yes.
- Should package latest version
Yes it's the latest
Issues:
1) I'm not entirely sure why to be honest but in the past I've been asked to change
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
to
make pure_install DESTDIR=$RPM_BUILD_ROOT
2) You have in your .spec file an explicit
Requires: perl(Nagios::Plugin)
Requires: perl(WWW::Mechanize)
which results in double entries in the requires from
rpm -qp --requires perl-Nagios-Plugin-WWW-Mechanize-0.13-2.fc14.noarch.rpm
As a gneral rule if yours requires are being auto determined you should not include
them explicitly.
3) Something I try and do is when you have a BuildRequires that is only needed on EL6
then I place it inside an OS conditional
http://fedoraproject.org/wiki/DistTag#Conditionals
This makes it obvious that when RHEL6 is buried you can get rid of these lines. Of course
sometimes it is requirement since the dependency names changes between releases.
Thank you Steve. I've updated to a -3 release. http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize.spec http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6.src.rpm ChangeLog for -3: - use DESTDIR in place of PERL_INSTALL_ROOT - rm explicit Requires (Nagios::Plugin and WWW::Mechanize are auto-determined) - Wrap BuildRequires for EL6 in a conditional DistTag Koji scratch builds: F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884086 F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884080 F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884082 EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884084 Removing FE-NEEDSPONSOR from this review, per https://fedorahosted.org/fesco/ticket/569 Looks GOOD. APPROVED. New Package SCM Request ======================= Package Name: perl-Nagios-Plugin-WWW-Mechanize Short Description: Login to a web page as a user and get data as a Nagios plugin Owners: ktdreyer Branches: f14 f15 el6 Git done (by process-git-requests). perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc14 perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc15 perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc15 has been pushed to the Fedora 15 stable repository. perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc14 has been pushed to the Fedora 14 stable repository. perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: perl-Nagios-Plugin-WWW-Mechanize New Branches: EL-5 Owners: ktdreyer The requisite WWW::Mechanize module is now in EPEL 5. Git done (by process-git-requests). |