Bug 682337

Summary: assumes all network devices are named ethX or trX
Product: [Fedora] Fedora Reporter: Bill Nottingham <notting>
Component: amtuAssignee: Steve Grubb <sgrubb>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 15CC: ebenes, rvokal, sgrubb, the.ridikulus.rat
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 682339 (view as bug list) Environment:
Last Closed: 2012-05-14 15:49:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 682334, 682339    
Attachments:
Description Flags
Patch... just read all devices with proper addresses none

Description Bill Nottingham 2011-03-04 21:24:52 UTC 
Created attachment 482379 [details]
Patch... just read all devices with proper addresses

Description of problem:

Network devices can have arbitrary names, and due to http://fedoraproject.org/wiki/Features/ConsistentNetworkDeviceNaming, will have different names in Fedora 15.

amtu assumes all devices are ethX or trX.

Version-Release number of selected component (if applicable):

amtu-1.0.8

How reproducible:

Via source code inspection
Comment 1 Steve Grubb 2011-06-24 19:03:21 UTC 
Not sure this patch is adequate. The system could have tunnels and bridges and other things that amtu should not touch. How do you identify just ethernet and tokenring interfaces in the new naming scheme?
Comment 2 Bill Nottingham 2011-06-24 19:42:19 UTC 
What is amtu verifying about the adapter that makes a bridge or bonded adapter invalid?
Comment 3 Steve Grubb 2011-06-24 20:07:39 UTC 
The code is just to check that the basic security assumptions are met, meaning you have lossless IO. There is a programming note that the test does not work for async network devices. So, I think the code looks for ethernet and tokenring knowing they are not async.
Comment 4 Bill Nottingham 2011-06-24 20:16:20 UTC 
Probably keying off of the header type (/sys/class/net/<device>/type, see include/linux/if_arp.h for the list) is best then?
Comment 5 Steve Grubb 2012-05-14 15:49:41 UTC 
Applied patch.