Bug 682350

Summary:	assumes network devices are named certain things
Product:	Red Hat Enterprise Linux 6	Reporter:	Bill Nottingham <notting>
Component:	iptraf	Assignee:	Nikola Pajkovsky <npajkovs>
Status:	CLOSED ERRATA	QA Contact:	Aleš Mareček <amarecek>
Severity:	medium	Docs Contact:
Priority:	high
Version:	6.1	CC:	amarecek, dhoward, jentrena, mvadkert, npajkovs, ovasik, rdassen, rfreire, rvokal, stufently
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	682348	Environment:
Last Closed:	2012-06-20 12:08:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	682348
Bug Blocks:	727267, 747123, 756082

Description Bill Nottingham 2011-03-04 21:47:34 UTC

+++ This bug was initially created as a clone of Bug #682348 +++

Created attachment 482389 [details]
Patch

Description of problem:

Network devices can have arbitrary names, and due to
http://fedoraproject.org/wiki/Features/ConsistentNetworkDeviceNaming, will have
different names in Fedora 15.

ifaces.c:

char ifaces[][6] =
    { "lo", "eth", "sl", "ppp", "ippp", "plip", "fddi", "isdn", "dvb",
    "pvc", "hdlc", "ipsec", "sbni", "tr", "wvlan", "wlan", "sm2", "sm3",
    "pent", "lec", "brg", "tun", "tap", "cipcb", "tunl", "vlan", "hsi",
    "ctc", "ath", "bond"
};

It matches against this to determine whether an interface is supported.

Version-Release number of selected component (if applicable):

iptraf-3.0.1

How reproducible:

Visible by code inspection.

The attached patch fixes this by always accepting device names. Seems like a better idea than trying to extend the whitelist.

Comment 1 Bill Nottingham 2011-03-04 21:53:30 UTC

Needs some further fixes; promisc.c:init_promisc_list() and
packet.c:getlinktype() are similarly broken.

Comment 3 RHEL Program Management 2011-03-04 22:18:04 UTC

This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 4 Rodrigo A B Freire 2011-10-13 16:58:38 UTC

*** Bug 706317 has been marked as a duplicate of this bug. ***

Comment 9 Rodrigo A B Freire 2012-03-02 22:41:09 UTC

*** Bug 759604 has been marked as a duplicate of this bug. ***

Comment 12 errata-xmlrpc 2012-06-20 12:08:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0762.html