Bug 682489

Summary: Review Request: drupal6-acidfree - A full-featured media management system for Drupal
Product: [Fedora] Fedora Reporter: eric
Component: Package ReviewAssignee: Paul W. Frields <stickster>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, stickster
Target Milestone: ---Flags: stickster: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-10 05:20:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 682486, 682487, 682488    
Bug Blocks:    

Description eric 2011-03-06 01:26:12 UTC
Spec URL: http://sparks.fedorapeople.org/Packages/drupal6-acidfree.spec

SRPM URL: http://sparks.fedorapeople.org/Packages/drupal6-acidfree-6.x.1.0.beta2-1.fc14.src.rpm

Description: 
A full-featured media management system for drupal. This makes it so you can 
easily manage your photos and videos with drupal. Acidfree albums and media 
items are drupal nodes to integrate better into your system. It offers 
themeable drawing routines for albums and each media type so it can fit in 
better with the rest of your website. Items can be added individually (the 
drupal node-centric method) and also via a mass-import page that allows server-
side directories of media to be imported or zipped, bzipped or gzipped archives
to be uploaded and imported.

Comment 1 Paul W. Frields 2011-04-06 00:22:22 UTC
Hey Eric, a couple things that need fixing:

* %exclude the documentation that's currently showing up in %{_datadir}/drupal6. (LICENSE, README, UPGRADE, CHANGELOG.)

* The version you're using needs fixing. The 6.x should not appear there, that's what the '6' in 'drupal6' is for. Check the specfile template on the wiki for an example: https://fedoraproject.org/wiki/Drupal_module_specfile_template

* The release tag also needs fixing, since this is a pre-release. Read http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages for more information. This should be something like: 0.1.beta2%{?dist}

All together the NVR would be: drupal6-acidfree-1.0-0.1.beta2%{?dist}

Feel free to NEEDINFO me when you put your next attempt up and I'll get right to it.

Comment 2 Paul W. Frields 2011-06-26 15:46:53 UTC
Any update for this package, Eric?

Comment 3 Paul W. Frields 2011-08-26 19:57:20 UTC
Hi Eric, hopefully the changes I made to some of your other packages show what needs to be done for this one.  If you don't have time to work on this package, let me know and I'll release the review for now.