Bug 682513

Summary: VDSM - Storage: VDSM should work with new mke2fs default of discard=enabled
Product: Red Hat Enterprise Linux 6 Reporter: Daniel Paikov <dpaikov>
Component: vdsmAssignee: Erez Shinan <erez>
Status: CLOSED ERRATA QA Contact: Jakub Libosvar <jlibosva>
Severity: high Docs Contact:
Priority: high    
Version: 6.1CC: abaron, bazulay, danken, hateya, iheim, ilvovsky, ykaul
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: vdsm-4.9-65.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 07:08:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
vdsm.log none

Description Daniel Paikov 2011-03-06 10:15:27 UTC
Created attachment 482503 [details]
vdsm.log

As of RHEL 6.1, mke2fs has a default of discard=enabled. Creating new storage domain on a storage that doesn't support discard now fails with the following errors. We should disable discard on our side by using "mke2fs -K".

I'll test this on RHEL 6.0 to see whether the default there is already discard=enabled. I'll update this bug when I have new info.

Thread-4576::DEBUG::2011-03-03 11:47:20,433::blockSD::913::Storage.Misc.excCmd::(_cr
eateVMSfs) FAILED: <err> = 'Warning: could not erase sector 2: Attempt to write bloc
k from filesystem resulted in short write\nWarning: could not read block 0: Attempt
to read block from filesystem resulted in short read\nWarning: could not erase secto
r 0: Attempt to write block from filesystem resulted in short write\n\nWarning, had
trouble writing out superblocks.'; <rc> = 1
Thread-4576::ERROR::2011-03-03 11:47:20,434::task::854::TaskManager.Task::(_setError
) Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 862, in _run
    return fn(*args, **kargs)
  File "/usr/share/vdsm/storage/hsm.py", line 1199, in public_createStorageDomain
    domClass=domClass, typeSpecificArg=typeSpecificArg, version=domVersion)
  File "/usr/share/vdsm/storage/sdf.py", line 60, in create
    version=version)
  File "/usr/share/vdsm/storage/blockSD.py", line 286, in create
    _createVMSfs(os.path.join("/dev", vgName, MASTERLV))
  File "/usr/share/vdsm/storage/blockSD.py", line 915, in _createVMSfs
    raise se.MkfsError(dev)
MkfsError: Cannot create filesystem on device: ('/dev/3a135f20-612f-4bf4-8081-2e1fd4
767ea7/master',)

Comment 2 Daniel Paikov 2011-03-06 12:27:16 UTC
I tested this on RHEL 6.0, mke2fs fails on 6.0 as well.

Comment 3 Erez Shinan 2011-05-05 13:27:29 UTC
http://gerrit.usersys/#change,370

Comment 5 Jakub Libosvar 2011-05-18 14:41:34 UTC
Verified in vdsm-4.9-67.el6.x86_64

Comment 6 errata-xmlrpc 2011-12-06 07:08:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2011-1782.html