Bug 682690

Summary: Ejecting a busy floppy from guest causes I/O error
Product: Red Hat Enterprise Linux 6 Reporter: zhanghaiyan <yoyzhang>
Component: libvirtAssignee: Daniel Veillard <veillard>
Status: CLOSED NOTABUG QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: low    
Version: 6.1CC: dyuan, eblake, jdenemar, llim, xen-maint, ydu
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-07 10:06:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
I/O error in guest none

Description zhanghaiyan 2011-03-07 09:47:53 UTC
Description of problem:
Ejecting a busy floppy from guest causes I/O error

Version-Release number of selected component (if applicable):
- libvirt-0.8.7-8.el6.x86_64
- kernel-2.6.32-114.0.1.el6.x86_64
- qemu-kvm-0.12.1.2-2.144.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1. Add a floppy to guest xml 
    </disk>
      <disk type='block' device='floppy'>
      <driver name='qemu' type='raw'/>
      <source dev='/var/lib/libvirt/images/floppy1.img'/>
      <target dev='fda' bus='fdc'/>
    </disk>
2. Define and start the guest
3. In guest, 
# modprobe floppy
# mount /dev/fd0 /mnt
4.Prepare a eject.xml
# cat eject.xml 
   <disk type='block' device='floppy'>
     <target dev='fda' bus='fdc'/>
   </disk>
5. # virsh update-device rhel61_i386_11 eject.xml 
Device updated successfully

Actual results:
5. Could eject a busy floppy in guest without --force, and seconds later, could see I/O error in guest (please see the attachment)

Expected results:
6. Should cannot eject a busy floppy in guest without --force, surely should not cause I/O error in guest

Additional info:

Comment 1 zhanghaiyan 2011-03-07 09:49:37 UTC
Created attachment 482636 [details]
I/O error in guest

Comment 3 Jiri Denemark 2011-03-07 10:06:40 UTC
The actual results are in fact expected. Floppy drives, unlike CD-ROM drives, do not support locking the media in. Thus the drive (qemu) doesn't know whether the floppy is mounted in the guest or not.