Bug 682786

Summary: Review Request: gpick - Advanced color picker written in C++ using GTK+ toolkit
Product: [Fedora] Fedora Reporter: Paul W. Frields <pfrields>
Component: Package ReviewAssignee: Mohamed El Morabity <pikachu.2014>
Status: CLOSED INSUFFICIENT_DATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, pikachu.2014, rc040203
Target Milestone: ---Flags: pikachu.2014: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-04-15 15:58:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch to enable compilation/linking logs none

Description Paul W. Frields 2011-03-07 15:37:01 UTC 
Spec URL: http://pfrields.fedorapeople.org/packages/SPECS/gpick.spec
SRPM URL: http://pfrields.fedorapeople.org/packages/SRPMS/gpick-0.2.3-1.fc14.src.rpm
Description: gpick is an advanced color picker written in C++ using the GTK+ toolkit. It has an array of advanced features such as creating palettes from images, color scheme creation, magnification, import/export in multiple formats, and more.
Comment 1 Mohamed El Morabity 2011-03-07 15:52:49 UTC 
I will review it.
Comment 2 Paul W. Frields 2011-03-07 15:56:10 UTC 
Whoops, there are a bunch of bundled things I missed in the source. I'm working on this, will update bug when I fix them. Please wait on your review until then, and thank you for your quick response!
Comment 3 Ralf Corsepius 2011-03-07 16:01:22 UTC 
Just some comments (MUSTFIXES):

# rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*rpm
gpick.src: W: invalid-url Source0: http://gpick.googlecode.com/files/gpick_0.2.3.tar.gz HTTP Error 404: Not Found
gpick-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 1 errors, 1 warnings.

=> broken debuginfos

Likely your package doesn't honor RPM_OPT_FLAGS.


Unfortunately it's impossible to tell because the logs being produced don't provide sufficient information:
...
Compiling ==> build/source/gtk/Swatch.o
Compiling ==> build/source/gtk/Zoomed.o
Compiling ==> build/source/layout/Box.o
Compiling ==> build/source/layout/Layout.o
Compiling ==> build/source/layout/LuaBindings.o  
Compiling ==> build/source/layout/ReferenceCounter.o 
Compiling ==> build/source/layout/Style.o
Compiling ==> build/source/layout/System.o
...
=> make the build process verbose.
Comment 4 Mohamed El Morabity 2011-03-07 16:53:32 UTC 
> Unfortunately it's impossible to tell because the logs being produced don't
> provide sufficient information:
In the meantime, to enable compilation logs, all the XXXCOMSTR should be unset in SConscript. The attached patch removes all definitions of these variables.
Comment 5 Mohamed El Morabity 2011-03-07 16:54:24 UTC 
Created attachment 482728 [details]
Patch to enable compilation/linking logs
Comment 6 Mohamed El Morabity 2011-04-15 01:22:02 UTC 
Are you still OK with this package? Do you need any kind of help?
Comment 7 Paul W. Frields 2011-04-15 15:58:18 UTC 
I've had very little time to work on this since my last email.  There are a number of bundled libraries that will need to be untangled and worked through before this is close to packaging.  I probably need to withdraw this review request until I get more time to fix those problems.  There's no good CLOSED reason other than INSUFFICIENT_DATA for this -- packaging is not really ready for review yet.