Bug 682813

Summary: corosync does not null terminate strings when strncpy
Product: Red Hat Enterprise Linux 6 Reporter: Steven Dake <sdake>
Component: corosyncAssignee: Steven Dake <sdake>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: low    
Version: 6.2CC: cluster-maint, djansa, jfriesse, jkortus
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: corosync-1.4.0-1.el6 Doc Type: Bug Fix
Doc Text:
Do not document.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 11:50:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
upstream patch to fix the problem none

Description Steven Dake 2011-03-07 16:30:41 UTC 
Description of problem:
Corosync does not null terminate strings when strncpy is the length of the string being copied.  I am not entirely sure if this is a real problem, but could expose as a security issue.

Version-Release number of selected component (if applicable):

corosync-1.2.3

How reproducible:

can't generate failure - found via inspection by upstream

Steps to Reproduce:
1.
2.
3.
  
Actual results:
strncpy is not null terminating strings

Expected results:
strncpy is null terminating strings

Additional info:
Comment 1 Steven Dake 2011-03-07 16:32:33 UTC 
Created attachment 482723 [details]
upstream patch to fix the problem
Comment 9 Steven Dake 2011-10-27 18:37:32 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Do not document.
Comment 10 errata-xmlrpc 2011-12-06 11:50:12 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1515.html