Bug 682823

Summary: Bogus Requires: line in netcf.pc cause unnecessary direct library linkage in apps
Product: [Fedora] Fedora Reporter: Daniel BerrangĂ© <berrange>
Component: netcfAssignee: Laine Stump <laine>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 14CC: laine, lutter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-12 13:26:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Daniel Berrangé 2011-03-07 17:16:47 UTC
Description of problem:
The pkgconfig file for netcf includes a line:

   Requires: augeas >= 0.5.0 libxml-2.0 libxslt

The semantics of the 'Requires' line is that this lists deps that need to be included on the compiler command line in order to compile netcf.

 ie,  -I /usr/include/libxml2

This would only be required if  netcf.h actually exposed some part of augeas, libxml or libxslt in its public API. This is not the case, the use of these libraries is an entirely private implementation detail. Thus the 'Requires:' line should be killed.

NB if you want to support static linking with netcf you would want to change 'Requires' to "Requires.private", but I'd just not support static libs myself.

Version-Release number of selected component (if applicable):
netcf-0.1.7-1.fc14.x86_64

How reproducible:
Always

Steps to Reproduce:
1.$ pkg-config --libs --cflags netcf
2.
3.
  
Actual results:
-I/usr/include/libxml2  -lnetcf -laugeas -lxslt -lz -lm -lxml2  


Expected results:
-lnetcf


Additional info:

Comment 1 Laine Stump 2011-05-12 13:26:14 UTC

*** This bug has been marked as a duplicate of bug 662056 ***