| Summary: | Review Request: lio-utils - Utilities for Generic Target Infrastructure | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andy Grover <agrover> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bperkins, fedora-package-review, mchristi, ncjeffgus, notting, terje.rosten, tomek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-07 22:47:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 744340 | ||
|
Description
Andy Grover
2011-03-07 22:45:35 UTC
I've probably asked this before, but what's the way forward between this, scsi-target-utils, scst, etc? LIO was accepted upstream over scst. Long-term, scsi-target-utils will be deprecated in favor of LIO. The exact timing and method of that transition is still TBD. Some comments:
a) no url tag, where is this project living?
b) you might want to add the sha1 8ad98e3 to the tarball name?
c) -n %{name}-%{version} in %setup is the default and can be dropped
(however, consider b))
d) mixing of $RPM_BUILD_ROOT and %{buildroot}, pick one.
e) use macros for /etc, /sbin and /etc/init.d/
f) target is a very generic name, possible problem
g) change %defattr(-,root,root) -> %defattr(-,root,root,-)
h) the package seems to be free for docs and with no url tag, the user
will have a hard time be able to use this utility.
i) Release: 1, please add disttag here.
j) it builds in koji, however correct %{optflags} is not used:
http://koji.fedoraproject.org/koji/getfile?taskID=2895139&name=build.log
http://koji.fedoraproject.org/koji/taskinfo?taskID=2895138
(In reply to comment #3) > Some comments: > > a) no url tag, where is this project living? > b) you might want to add the sha1 8ad98e3 to the tarball name? > c) -n %{name}-%{version} in %setup is the default and can be dropped > (however, consider b)) I decided to keep the tarball name, since future releases should have proper tarballs. > d) mixing of $RPM_BUILD_ROOT and %{buildroot}, pick one. > e) use macros for /etc, /sbin and /etc/init.d/ > f) target is a very generic name, possible problem True.. it's what upstream is using, so I'm hesitant to diverge. > g) change %defattr(-,root,root) -> %defattr(-,root,root,-) > h) the package seems to be free for docs and with no url tag, the user > will have a hard time be able to use this utility. Yeah, I'll be working with upstream to author some manpages. > i) Release: 1, please add disttag here. All the rest are done. Revised versions: http://fedorapeople.org/~grover/lio-utils.spec(2) http://fedorapeople.org/~grover/srpms/lio-utils-3.2-1.src.rpm Whups, added optflags and made disttag conditional. http://fedorapeople.org/~grover/lio-utils.spec3 http://fedorapeople.org/~grover/srpms/lio-utils-3.2-3.el6.src.rpm Would be simpler to follow if you add a real changelog. This package has been superseded by targetcli, so I'm closing this one. |