Bug 683100

Summary:	virtinst incorrectly parses domain <features>, breaks virt-manager overview changes
Product:	Red Hat Enterprise Linux 6	Reporter:	Cole Robinson <crobinso>
Component:	python-virtinst	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.1	CC:	dallan, dyuan, mhideo, mjenner, nzhang, xen-maint, zpeng
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	When changing the acpi or apic values in virt-manager, virtinst would unset the values. This change now checks for the feature and ensures the value is retained allowing virtinst to parse domain features correctly.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-19 13:43:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Cole Robinson 2011-03-08 15:07:32 UTC

Changing acpi/apic values on the overview page in virt-manager does not work, virtinst will unconditionally unset the values.

Fixed upstream here:

http://hg.fedorahosted.org/hg/python-virtinst/rev/34bafa85c55f

This is a regression from 6.0 so needs to be fixed, and the fix is low risk.

Comment 1 Cole Robinson 2011-03-10 18:25:04 UTC

Fixed in python-virtinst-0.500.5-2.el6

Comment 3 Nan Zhang 2011-03-18 08:43:59 UTC

Now can unset acpi/apic values with python-virtinst-0.500.5-2.el6.noarch, move to VERIFIED.

# virt-install -n test1 -r 512 --cdrom /var/lib/libvirt/boot/Fedora-14-i686-Live-Desktop.iso --vcpus=2 -f /var/lib/libvirt/images/test1.img -s 5 --hvm --accelerate --os-variant=virtio26 --network network:default --noreboot --vnc --noacpi --noapic

# virsh dumpxml test1
(...)
  <features>
    <pae/>
  </features>
(...)

Comment 4 zhe peng 2011-04-18 03:38:50 UTC

verified this bug with:
Linux localhost.localdomain 2.6.32-130.el6.x86_64 #1 SMP Tue Apr 5 19:58:31 EDT
2011 x86_64 x86_64 x86_64 GNU/Linux

python-virtinst-0.500.5-3.el6.noarch
libvirt-0.8.7-17.el6.x86_64

passed.

Comment 6 Michael Hideo 2011-05-12 23:00:09 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
* When changing the acpi or apic values in virt-manager, virtinst would unset the values. This change now checks for the feature and ensures the value is retained allowing  virtinst to parse domain features correctly. (BZ#683100)

Comment 7 Michael Hideo 2011-05-16 21:39:56 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-* When changing the acpi or apic values in virt-manager, virtinst would unset the values. This change now checks for the feature and ensures the value is retained allowing  virtinst to parse domain features correctly. (BZ#683100)+When changing the acpi or apic values in virt-manager, virtinst would unset the values. This change now checks for the feature and ensures the value is retained allowing  virtinst to parse domain features correctly.

Comment 8 errata-xmlrpc 2011-05-19 13:43:27 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0636.html