Bug 683117

Summary: kernel config option LEGACY_PTYS (bool) should not have a range
Product: Red Hat Enterprise Linux 4 Reporter: Harald Klein <hklein>
Component: kernelAssignee: Mauro Carvalho Chehab <mchehab>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: low Docs Contact:
Priority: medium    
Version: 4.9CC: dhoward, jpallich, kzhang, lwang, mchehab, pcfe, rdassen
Target Milestone: rcKeywords: CodeChange, EasyFix
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: 2.6.9-103 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-08 10:58:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 494835    
Attachments:
Description Flags
Move the Legacy PTY range to the right place none

Description Harald Klein 2011-03-08 15:51:25 UTC
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -474,6 +474,7 @@ config UNIX98_PTYS
 config LEGACY_PTYS
        bool "Legacy (BSD) PTY support"
        default y
+       range 0 4096
        ---help---
          A pseudo terminal (PTY) is a software device consisting of two
          halves: a master and a slave. The slave device behaves identical to

LEGACY_PTYS being a bool, it should not go up to 4096, CONFIG_LEGACY_PTY_COUNT is what should have a range.

This leads to a warning:
drivers/char/Kconfig:477:warning: range is only allowed for int or hex symbols
drivers/char/Kconfig:477:warning: range is invalid

It was introduced by:
commit 537ab167ec2e3175c3d5bf36ab44ab756d88abae
Author: Mauro Carvalho Chehab <mchehab>
Date:   Tue Sep 22 15:48:18 2009 -0300
pty: namespace for more than 256 devices when legacy pty support is enabled

Comment 2 Mauro Carvalho Chehab 2011-03-11 13:00:57 UTC
Created attachment 483710 [details]
Move the Legacy PTY range to the right place

Comment 8 Don Howard 2011-11-14 23:29:31 UTC
A patch addressing this issue has been included in kernel-2.6.9-103.

Comment 11 errata-xmlrpc 2011-12-08 10:58:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1796.html