Bug 683382

Summary:	VDSM: remove dual nic logic handling
Product:	[Retired] oVirt	Reporter:	Barak <bazulay>
Component:	vdsm	Assignee:	Dan Kenigsberg <danken>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	unspecified	CC:	abaron, bazulay, iheim, syeghiay, ykaul
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	network
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-11-30 19:39:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	683375
Bug Blocks:

Description Barak 2011-03-09 10:07:50 UTC

This logic was used because we needed to have network on the initial boot of a VM
(sysprep & domain registration) while the pv driver did not reside in the VM
by default.

This has changed since all drivers went through WHQL.

Comment 2 Dan Kenigsberg 2011-03-12 23:06:55 UTC

I don't see the point in touching the code on vdsm side. It's quite old and tested and harmless. It make (some kind of) sense as it is (duplicate mac addresses to nics without respective addresses).

Comment 3 RHEL Program Management 2011-04-04 02:14:35 UTC

Since RHEL 6.1 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 5 Dan Kenigsberg 2012-11-30 19:39:51 UTC

This issue is nicely tucked into vm.Vm.getConfNetworkInterfaces(), which would be removed when ovirt-3.0's is decommissioned.

http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob;f=vdsm/vm.py;h=73e3f3f480f7f86daba812c8ad42f1b8e38fe189;hb=4e714858842a39cde700ba398b6ab03a9d14fd26#l558