Bug 68339

Summary: packer.h missing in binary rpm
Product: [Fedora] Fedora Reporter: Joerg Dorchain <joerg>
Component: cracklibAssignee: Nalin Dahyabhai <nalin>
Status: CLOSED RAWHIDE QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: 1CC: bkw, dr, jtate
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-01-29 01:48:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Joerg Dorchain 2002-07-09 12:19:03 UTC
Description of Problem:
the packer.h include file is not installed with the current spec file
some programs, e.g. php-4.2.1 test for it.

Version-Release number of selected component (if applicable):
I checked cracklib-2.7-8 from the 7.1 release and cracklib-2.7-18 from rawhide

How Reproducible:
Always

Steps to Reproduce:
Build the package and install it.

Actual Results:
packer.h is not installed

Expected Results:
packer.h in /usr/include next to crack.h

Additional Information:
The following patch fixes it. it is against the 	2.7-18 spec file
--- cracklib.spec.redhat	Tue Jul  9 14:07:53 2002
+++ cracklib.spec	Tue Jul  9 14:10:57 2002
@@ -101,6 +101,7 @@
 	includedir=%{_includedir} \
 	libdir=%{_libdir} \
 	sbindir=%{_sbindir}
+cp cracklib/packer.h $RPM_BUILD_ROOT/%{_includedir}
 
 %post -p /sbin/ldconfig

Comment 1 Joseph Tate 2003-11-10 16:01:01 UTC
Why in the world has this not been fixed?  A patch was provided, there
are no other files that would conflict with the change

Still exists in RHL 9, FC 1, and RHEL 3.

Here is a patch that fixes the Makefile to install packer.h as well as
crack.h

diff -uNr cracklib,2.7/cracklib/Makefile
cracklib,2.7-changed/cracklib/Makefile
--- cracklib,2.7/cracklib/Makefile      Thu Jan  3 14:37:25 2002
+++ cracklib,2.7-changed/cracklib/Makefile      Thu Jan  3 14:15:23 2002
@@ -22,7 +22,8 @@
 clean:
        -rm -f $(OBJ) $(LIB) $(LIB).$(VERSION) *~

-install: $(LIB) crack.h
+install: $(LIB) crack.h packer.h
        install -m 755 $(LIB).$(VERSION) $(ROOT)$(libdir)
        ln -sf $(LIB).$(VERSION) $(ROOT)$(libdir)/$(LIB)
        install -m 644 crack.h $(ROOT)$(includedir)
+       install -m 644 packer.h $(ROOT)$(includedir)


Since this section is modified by the cracklib-2.7-rh.patch it's only
fitting that packer.h be installed as well.

Comment 2 Joseph Tate 2003-11-10 16:35:39 UTC
triage->easyfix

use my patch inlined above in the SPEC file.  Ignore the first patch.

Comment 3 Daniel Roesen 2004-01-28 23:25:34 UTC
Nalin, could you please comment?
I've just waste about 30 minutes finding out why this was broken when
I tried building PHP here. The fix is EASY.

Can we please get this fixed for at least FC2?

Comment 4 Daniel Roesen 2004-01-29 00:40:09 UTC
Alan asked for upgrading of product/version. Doing so.

Comment 5 Karsten Hopp 2004-01-29 01:48:21 UTC
Nalin added the patch last year and forgot to build the package ;-) 
....fixed 

Comment 6 Daniel Roesen 2004-01-29 01:57:28 UTC
*** Bug 113030 has been marked as a duplicate of this bug. ***