Bug 683790

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2900098

I'm taking this one.

- License is MIT.
- The defined %ruby_sitelib macro is never used, so please remove it.
- You should use %global instead of %define, according to [1].
- You don't need to specify BuildRoot tag, see [2]
- Could you explain the Requires: rubygem(rubyforge) and Requires: rubygem(gemcutter)? I don't see why the library wouldn't work without them.
- Simlarly, can you explain the BuildRequires: rubygem(yard)? I don't see what you need yard for during the build.
- You don't need to use the "%defattr(-, root, root, -)" line, see [3]
- Consider moving documentation into a subpackage (except of README.rdoc, which contains licensing info and therefore should be left in the main package).
- rpmbuild complains about History.rdoc and Manifest.txt listed twice. To solve it:
** the package shouldn't own the whole %{gemdir}/gems/%{gemname}-%{version}/ directory (BTW you can use %{geminstdir} instead of it), but should rather own %dir %{geminstdir}
** when you do that, you will need to add every subdirectory and file in %{geminstdir} to %files, but you will be able to avoid the complaints about files listed twice

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
[2] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
[3] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

Ping, any progress on this one?

Hi Bohuslav,

Yes, it is on my radar, I expect that I could move with this during weekend/next week.

(In reply to comment #3)
> - License is MIT.
- Fixed

> - The defined %ruby_sitelib macro is never used, so please remove it.
- Fixed

> - You should use %global instead of %define, according to [1].
- Fixed

> - You don't need to specify BuildRoot tag, see [2]
- I know, as there is still open possibility to have this for EPEL in future, I keep it there.

> - Could you explain the Requires: rubygem(rubyforge) and Requires:
> rubygem(gemcutter)? I don't see why the library wouldn't work without them.
> - Simlarly, can you explain the BuildRequires: rubygem(yard)? I don't see what
> you need yard for during the build.
- Fixed
BuildRequires on rubygem(yard) is there because build fail without it, due to [1]

> - You don't need to use the "%defattr(-, root, root, -)" line, see [3]
- Yes, I'm aware of that, however i prefer to keep it there

> - Consider moving documentation into a subpackage (except of README.rdoc, which contains licensing info and therefore should be left in the main package).
- Documentation is too small to put it into subpackage, not worth of effort.

> - rpmbuild complains about History.rdoc and Manifest.txt listed twice. To solve
> it:
> ** the package shouldn't own the whole %{gemdir}/gems/%{gemname}-%{version}/
> directory (BTW you can use %{geminstdir} instead of it), but should rather own
> %dir %{geminstdir}
> ** when you do that, you will need to add every subdirectory and file in
> %{geminstdir} to %files, but you will be able to avoid the complaints about
> files listed twice
- Could not reproduce, works for me correctly (rpmlint-1.3.2).

[1] https://github.com/postmodern/hoe-yard/issues/1

Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-hoe-yard.spec
SRPM URL:
http://hpejakle.fedorapeople.org/packages/rubygem-hoe-yard-0.1.2-2.fc15.src.rpm

(In reply to comment #6)
> > - You don't need to specify BuildRoot tag, see [2]
> - I know, as there is still open possibility to have this for EPEL in future, I
> keep it there.

Ah, I see. All right.

> > - You don't need to use the "%defattr(-, root, root, -)" line, see [3]
> - Yes, I'm aware of that, however i prefer to keep it there
> 

Any reasons for this? If it is not necessary, I recommend putting it away.

> > - Consider moving documentation into a subpackage (except of README.rdoc, which contains licensing info and therefore should be left in the main package).
> - Documentation is too small to put it into subpackage, not worth of effort.
> 

Ok, this is not a blocker, but next time, consider using gem2rpm from package rubygem-gem2rpm, which will generate a nice scaffold and you won't have to take care of this yourself.

> > - rpmbuild complains about History.rdoc and Manifest.txt listed twice. To solve
> > it:
> > ** the package shouldn't own the whole %{gemdir}/gems/%{gemname}-%{version}/
> > directory (BTW you can use %{geminstdir} instead of it), but should rather own
> > %dir %{geminstdir}
> > ** when you do that, you will need to add every subdirectory and file in
> > %{geminstdir} to %files, but you will be able to avoid the complaints about
> > files listed twice
> - Could not reproduce, works for me correctly (rpmlint-1.3.2).

Actually, you don't have to use rpmlint (and you are correct, it doesn't show this warning), it is written in build log, see my scratch build:

http://koji.fedoraproject.org/koji/getfile?taskID=3523114&name=build.log

Ah, I see now. I did not checked build.log as far as it was builded correctly and in past, rpmbuild was not successful when such error happened, at least on my system. I will take a look.

regarding %defattr, I'm used to specify it this way, kind of historical reasons :). Does it bring any risk to user/infrastructure?

(In reply to comment #8)
> regarding %defattr, I'm used to specify it this way, kind of historical reasons
> :). Does it bring any risk to user/infrastructure?

This macro is not necessary in any supported RHEL nor Fedora if I am not mistaken. May be it is time to move forward?

The same with the BuildRoot. I would like to see there some conditional use, for older releases. Then it will be obvious that in some point in the future, the BuildRoot could be safely removed.

So, any progress on this one?

Since there seems to be no progress here, I'm closing this bug. Feel free to reopen if you wish to restart the review.