Bug 683793

Summary:	Review Request: man-pages-overrides - Complementary and updated manual pages
Product:	Red Hat Enterprise Linux 5	Reporter:	Ivana Varekova <varekova>
Component:	Package Review	Assignee:	Miloslav Trmač <mitr>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.0	CC:	notting, ovasik, pm-rhel, rvokal
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-03-10 22:57:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	188273, 558469

Description Ivana Varekova 2011-03-10 11:42:22 UTC

Spec URL: http://people.redhat.com/varekova/man-pages-overrides.spec
SRPM URL: http://people.redhat.com/varekova/man-pages-overrides-0.5.7.0-1.fc13.src.rpm
Description: A collection of manual ("man") pages to complement other packages or update
those contained therein. Always have the latest version of this package
installed.

Comment 1 Miloslav Trmač 2011-03-10 22:57:54 UTC

Looks fine.  A few notes:

* License: is OK - but ONLY IF you plan to update it with each included man page

* %description: "Always have the latest version of this package installed."
  This feels a little strange - users can't read such instructions during
  installation, anyway.  There's nothing technically wrong with it, of course.

* I'd feel a little bit more comfortable if the %doc path and directory name
  were not hard-coded in the spec like this (so that nothing needed to be
  changed if RPM changed policy for locating or naming the %doc directories),
  but it's probably not worth the effort.

* Consider changing %install to preserve timestamps of installed files.

rpmlint:
> man-pages-overrides.src: W: no-url-tag
> man-pages-overrides.src: W: invalid-url Source0: man-pages-overrides-0.5.7.0.tar.gz
OK

> man-pages-overrides.src: W: no-%build-section
I'd suggest adding a %build section (empty or only containing a comment) for
clarity.

> man-pages-overrides.noarch: E: invalid-locale-man-dir /usr/share/man/overrides/man1/apropos.1.gz
> man-pages-overrides.noarch: W: file-not-in-%lang /usr/share/man/overrides/man1/apropos.1.gz
False positives - perhaps worth filing a rpmlint bug.