| Summary: | worthless "0 physical volumes not changed" message when combining PV tag arguments | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | Alasdair Kergon <agk> |
| Status: | CLOSED NOTABUG | QA Contact: | Corey Marthaler <cmarthal> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 6.1 | CC: | agk, dwysocha, heinzm, jbrassow, mbroz, prajnoha, prockai, thornber, zkabelac |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-09 14:56:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Corey Marthaler
2011-03-10 17:28:47 UTC
I found a case where the "not changed" number is > 0: [root@taft-01 ~]# pvscan PV /dev/sda2 VG vg_taft01 lvm2 [67.75 GiB / 0 free] PV /dev/sdb1 lvm2 [135.67 GiB] PV /dev/sdc1 lvm2 [135.67 GiB] PV /dev/sdd1 lvm2 [135.67 GiB] PV /dev/sde1 lvm2 [135.67 GiB] PV /dev/sdf1 lvm2 [135.67 GiB] PV /dev/sdg1 lvm2 [135.67 GiB] PV /dev/sdh1 lvm2 [135.67 GiB] Total: 8 [1017.41 GiB] / in use: 1 [67.75 GiB] / in no VG: 7 [949.66 GiB] [root@taft-01 ~]# pvchange --deltag 1 --deltag 2 /dev/sdb1 Can't change tag on Physical Volume /dev/sdb1 not in volume group 0 physical volumes changed / 1 physical volume not changed [root@taft-01 ~]# pvchange --deltag 1 --deltag 2 /dev/sdb1 /dev/sdc1 Can't change tag on Physical Volume /dev/sdb1 not in volume group Can't change tag on Physical Volume /dev/sdc1 not in volume group 0 physical volumes changed / 2 physical volumes not changed I'd still argue that this message is worthless. All the pvs on this system were "not changed", regardless of how many were listed on the cmdline. This is apparently not technical problem but question of wording and understandability. Alasdair, please can you comment it? Fix is either one liner (if you device to change it) or close as not-a-bug :-) s/device/decide :) Check the exit status too: if any are 'not changed' that indicates an error. Only the PVs specified on the cmdline are included - i.e. it's talking about "of the PVs you asked me to change, I changed X and didn't change Y". So the first two cases look right. The 3rd case could maybe be changed, but I'm not sure: Should we include /dev/foobar (which it discovered not to be a PV) in a total number of PVs? (In reply to comment #4) > I'm not sure: Should we include /dev/foobar (which it discovered not to be a > PV) in a total number of PVs? /dev/foobar is not a PV - naming nonexistent device a PV would be more confusing than it is today, I think. It's OK as it is. So I'm proposing CLOSED/NOTABUG. Corey, Alasdair? |