Bug 683941

Summary: [PATCH] Unbreak session LANG with gdm >= 2.91
Product: [Fedora] Fedora Reporter: Panu Matilainen <pmatilai>
Component: xfce4-sessionAssignee: Kevin Fenzi <kevin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 15CC: kevin, maxamillion
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: xfce4-session-4.8.1-3.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-19 05:51:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix session LANG with new gdm none

Description Panu Matilainen 2011-03-10 18:06:49 UTC
Created attachment 483528 [details]
Fix session LANG with new gdm

Description of problem:
UTF support in XFCE due to gdm change.

Version-Release number of selected component (if applicable):
xfce4-session-4.8.1, gdm >= 2.91

How reproducible:
Always

Steps to Reproduce:
1. Login to XFCE session
2. Start a program such as terminal
3. Edit / read non-ascii content
  
Actual results:
Non-ASCII characters are shown as question marks in terminal, XFCE GUI programs such as the file manager complain of invalid encoding if non-ascii characters are used in file names, gnome-terminal thinks its character encoding is ANSIX3.4-1968 etc.

Expected results:
Non-ascii characters should cause no problems.

Additional info:
xfce-session blindly resets LANG to the value of GDM_LANG if its set. The new Gnome 3 gdm sets GDM_LANG to an empty string, causing xfce-session change a proper LANG value to an empty string, causing this issue. Attached patch fixes it.

AFAICT both rawhide are affected.

Comment 1 Kevin Fenzi 2011-03-10 18:42:35 UTC
Excellent. Thank you. I have been meaning to track this down... 

Will get this applied and updates pushed out soon.

Comment 2 Fedora Update System 2011-03-10 19:00:22 UTC
xfce4-session-4.8.1-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/xfce4-session-4.8.1-3.fc15

Comment 3 Kevin Fenzi 2011-03-10 23:01:17 UTC
Adding upstream bug.

Comment 4 Fedora Update System 2011-03-19 05:51:07 UTC
xfce4-session-4.8.1-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.