Bug 684063

Summary: code defects in tcsh-6.17.00-glob-automount.patch
Product: Red Hat Enterprise Linux 6 Reporter: Kamil Dudka <kdudka>
Component: tcshAssignee: Vojtech Vitek <vvitek>
Status: CLOSED ERRATA QA Contact: Branislav Náter <bnater>
Severity: low Docs Contact:
Priority: low    
Version: 6.1CC: bnater, hripps, jkaluza, msvoboda, ovasik, praiskup, psplicha
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tcsh-6.17-13.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 17:02:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
defects fixed in tcsh-6.17-13.el6
none
defects added in tcsh-6.17-13.el6 none

Description Kamil Dudka 2011-03-11 01:14:40 UTC
Description of problem:
- suspicious call of blkend() with no effect
- suspicious assignments to variable 'res' with no effect


Version-Release number of selected component (if applicable):
tcsh-6.17-12.el6

Comment 3 RHEL Program Management 2011-03-11 01:37:51 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 9 Miroslav Svoboda 2011-08-30 10:42:23 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Prior to this update, the blkend() function was called redundantly in the tsch code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.

Comment 10 Kamil Dudka 2011-10-17 16:07:22 UTC
Created attachment 528577 [details]
defects fixed in tcsh-6.17-13.el6

Comment 11 Kamil Dudka 2011-10-17 16:07:49 UTC
Created attachment 528578 [details]
defects added in tcsh-6.17-13.el6

Comment 12 Kamil Dudka 2011-10-18 13:41:28 UTC
Comment on attachment 528578 [details]
defects added in tcsh-6.17-13.el6

>Error: FORWARD_NULL:
>/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:734: var_compare_op: Comparing "t->t_dcom" to null implies that "t->t_dcom" might be null.
>/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:740: var_deref_model: Passing null variable "t->t_dcom" to function "padd", which dereferences it.
>/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:820: var_assign_parm: Assigning: "argp" = "t->t_dcom".
>/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:820: deref_var: Dereferencing "argp", which equals a pointer parameter.

This defect ^^^ is not a regression.  It is either a false positive, or an old bug revealed by the tcsh-6.17.00-status-pipeline-backquote-list-of-cmds.patch.

Comment 13 Vojtech Vitek 2011-10-18 13:55:09 UTC
Thanks Kamil. I'm looking at the defects right now, I'm going to fix it soon..

Comment 14 Vojtech Vitek 2011-10-19 13:19:45 UTC
The original glob-automount patch has also some design issues, not only those coverity failures.

We are now testing the possible solutions with QA assignee..

Comment 16 Petr Šplíchal 2011-10-20 13:18:12 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-Prior to this update, the blkend() function was called redundantly in the tsch code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.+Prior to this update, the blkend() function was called redundantly in the tcsh code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.

Comment 21 Vojtech Vitek 2011-10-25 15:23:01 UTC
Deleted Technical Notes Contents.

Old Contents:
Prior to this update, the blkend() function was called redundantly in the tcsh code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.

Comment 24 Vojtech Vitek 2011-11-01 17:29:38 UTC
*** Bug 734357 has been marked as a duplicate of this bug. ***

Comment 25 errata-xmlrpc 2011-12-06 17:02:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1686.html