Bug 684065

Summary: missing parenthesis in backoff_from_master()
Product: [Fedora] Fedora Reporter: Kamil Dudka <kdudka>
Component: krb5Assignee: Nalin Dahyabhai <nalin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: nalin
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: krb5-1.9.1-5.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 684862 (view as bug list) Environment:
Last Closed: 2011-03-18 17:41:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 684862    

Description Kamil Dudka 2011-03-11 01:24:49 UTC
Description of problem:
statement with no effect


Version-Release number of selected component (if applicable):
krb5-1.9-6.fc16


Steps to Reproduce:
1. build the package

  
Actual results:
kpropd.c:996:9: warning: value computed is not used [-Wunused-value]


Additional info:
--- a/src/slave/kpropd.c
+++ b/src/slave/kpropd.c
@@ -993,7 +993,7 @@ unsigned int backoff_from_master(int *cnt) {
     btime = (unsigned int)(2<<(*cnt));
     if (btime > MAX_BACKOFF) {
         btime = MAX_BACKOFF;
-        *cnt--;
+        (*cnt)--;
     }

     return (btime);

Comment 2 Fedora Update System 2011-06-24 19:39:14 UTC
krb5-1.9.1-5.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/krb5-1.9.1-5.fc15

Comment 3 Fedora Update System 2011-07-06 21:35:58 UTC
krb5-1.9.1-5.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.