| Summary: | Review Request: perl-Catalyst-View-HTML-Template - HTML::Template View Class | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rc040203 |
| Target Milestone: | --- | Flags: | rc040203:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://search.cpan.org/dist/Catalyst-View-HTML-Template/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Catalyst-View-HTML-Template-0.03-2.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-21 03:32:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Iain Arnell
2011-03-11 04:43:47 UTC
This package looses a "requires:" when being built against Fedora < 15:
# rpm -q --requires -p /var/lib/mock/fedora-rawhide-x86_64/result/perl-Catalyst-View-HTML-Template-0.03-1.fc16.noarch.rpm | sort > requ.fc16
# rpm -q --requires -p /var/lib/mock/fedora-14-x86_64/result/perl-Catalyst-View-HTML-Template-0.03-1.fc14.noarch.rpm | sort > requ.fc14
# diff -u requ.fc14 requ.fc16
--- requ.fc14 2011-03-14 07:28:52.923752276 +0100
+++ requ.fc16 2011-03-14 07:29:07.337139204 +0100
@@ -1,4 +1,5 @@
perl(base)
+perl(Catalyst::View)
perl(HTML::Template)
perl(:MODULE_COMPAT_5.12.3)
perl(strict)
Please add something similar to this to your spec:
%if 0%{?fedora} < 15
Requires: perl(Catalyst::View)
%endif
Besides this, this is a clean and simple package, sources match upstream:
63a0055097d640b6d5b345815a96502d Catalyst-View-HTML-Template-0.03.tar.gz
installs cleanly, etc., etc.
I guess you are aware about
http://lists.fedoraproject.org/pipermail/perl-devel/2011-March/034369.html.
AFAIS, perl-Catalyst-Controller-FormBuilder has been added a filter to avoid depending on perl(Catalyst::Helper::View::HTML::Template)
IMO, this filter actually is wrong and should be removed once this package has entered Fedora.
APPROVED
(In reply to comment #1) > This package looses a "requires:" when being built against Fedora < 15: Well spotted. Will fix as you suggested. > I guess you are aware about > http://lists.fedoraproject.org/pipermail/perl-devel/2011-March/034369.html. > > AFAIS, perl-Catalyst-Controller-FormBuilder has been added a filter to avoid > depending on perl(Catalyst::Helper::View::HTML::Template) > > IMO, this filter actually is wrong and should be removed once this package has > entered Fedora. Agreed - that's why I've packaged it. > > APPROVED Thanks for the review. New Package SCM Request ======================= Package Name: perl-Catalyst-View-HTML-Template Short Description: - HTML::Template View Class Owners: iarnell Branches: f14 f15 InitialCC: perl-sig This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-raise the fedora-cvs flag. Please provide detailed instructions - I have no idea what I am supposed to do. New Package SCM Request ======================= Package Name: perl-Catalyst-View-HTML-Template Short Description: - HTML::Template View Class Owners: iarnell Branches: f14 f15 InitialCC: perl-sig Git done (by process-git-requests). perl-Catalyst-View-HTML-Template-0.03-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Catalyst-View-HTML-Template-0.03-2.fc15 perl-Catalyst-View-HTML-Template-0.03-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Catalyst-View-HTML-Template-0.03-2.fc14 perl-Catalyst-View-HTML-Template-0.03-2.fc15 has been pushed to the Fedora 15 testing repository. perl-Catalyst-View-HTML-Template-0.03-2.fc15 has been pushed to the Fedora 15 stable repository. perl-Catalyst-View-HTML-Template-0.03-2.fc14 has been pushed to the Fedora 14 stable repository. |