Bug 684189

Summary:	memory leak in quota-3.17-64-bit-quota-support.patch
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	quota	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	15	CC:	kdudka, ovasik, ppisar
Target Milestone:	---	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://sourceforge.net/tracker/?func=detail&aid=3206267&group_id=18136&atid=118136
Whiteboard:
Fixed In Version:	quota-4.00-0.9.pre1.fc15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	684017	Environment:
Last Closed:	2011-03-16 04:08:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Comment 1 Petr Pisar 2011-03-11 12:38:51 UTC

+++ This bug was initially created as a clone of Bug #684017 +++

Description of problem:
qtree_read_dquot() calls smalloc(info->dqi_entry_size) to allocate memory that
is never freed afterwards.

--- Additional comment from ppisar on 2011-03-11 09:56:18 GMT ---

You are right. The ddquot buffer is allocated, under a condition filled by data
and its content parsed and copied into dquot, and then the function exits. So
the ddquot buffer should be freed before return.

Upstream development version is affected too.

--- Additional comment from ppisar on 2011-03-11 10:01:28 GMT ---

The same bug is in qtree_write_dquot() in the same file.

[...]

--- Additional comment from ppisar on 2011-03-11 11:49:18 GMT ---

Created attachment 483694 [details]
Fix ddquot buffer leak

Fix submitted to upstream, it applies to RHEL-6 version cleanly, leaks in both
functions are covered.
----

quota-4.00_pre1 in F16--15 is affected too.

Comment 2 Fedora Update System 2011-03-11 12:55:59 UTC

quota-4.00-0.9.pre1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/quota-4.00-0.9.pre1.fc15

Comment 3 Fedora Update System 2011-03-16 04:08:20 UTC

quota-4.00-0.9.pre1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.