Bug 684398

I run rpmlint against srpms and rpms packages and there are some errors/warning I don't know how to fix. For srpms, the error is:

$ rpmlint Webilder-0.7-1.src.rpm 
Webilder.src:59: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers/*
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

I looked into one other applet that uses the same path, so I don't know what to set instead of this?

On rpm package, the warnings are:

$ rpmlint Webilder-0.7-1.x86_64.rpm 
Webilder.x86_64: E: no-binary
Webilder.x86_64: W: file-not-in-%lang /usr/lib/python2.7/site-packages/webilder/locale/fr/LC_MESSAGES/webilder.mo
Webilder.x86_64: W: file-not-in-%lang /usr/lib/python2.7/site-packages/webilder/locale/it/LC_MESSAGES/webilder.mo
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

I don't know what is this 'no-binary' about?! For lang warning, the problem is that the locales are not in the standard directory so find_lang is useless in this case. What should I do, manually specify that those are language file (how? just create file with a list and pass that file to %files macro) or should I move those locale files into appropriate global directory? In the letter case I don't know how the application will behave after that...

And I'm using this applet currently for a few days without any noticeable problem so far...

> $ rpmlint Webilder-0.7-1.src.rpm 
> Webilder.src:59: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers/*
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
what is /usr/lib/bonobo/servers/GNOME_WebilderApplet.server why it placed in /usr/lib? It's XML please correct setup-files

Package have broken BuildRequires 
1) You MUST add python-setuptools to BuildRequires
2) I get this message
error: Could not find module No module named gnomeapplet. Please fix it. I'm sure that you have to add gnome-python2-applet BR
Koji 
3) Possible others

Please add %{?dist} to Release.

You package contains locales (it and fr) but you doen't add they to rpm.

Koji build is failed.

Please correct this errors.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Some additions:
you should include desktop file. http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

Is it your first package?



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

I'm approved packager but this is my first python desktop package.

> what is /usr/lib/bonobo/servers/GNOME_WebilderApplet.server why it placed in
> /usr/lib? It's XML please correct setup-files

As far as I can see, those XML files really go into /usr/lib, the only problem is that on 64-bit platform they should be in /usr/lib64 but I don't know enough python setuptools to know where/how it is defined.
 
> Package have broken BuildRequires 
> 1) You MUST add python-setuptools to BuildRequires

Added.

> 2) I get this message
> error: Could not find module No module named gnomeapplet. Please fix it. I'm
> sure that you have to add gnome-python2-applet BR
> Koji 

Also added.

> 3) Possible others

Surrently I'm on slow/expensive link otherwise I would do mock build.

> Please add %{?dist} to Release.

Added.

> You package contains locales (it and fr) but you doen't add they to rpm.

I wrote in second comment that I have problem with locale files, again because they are installed in "wrong" location/path. So, I'm aware that they are here, and rpmlint complains about them, but I don't know what's best way to fix that.

Ok, I think gnome-applet-webilder is a more suitable name for package. 

I've tried to correct some mistakes (and koji is happy now :) ). Please check src.rpm 
http://landgraf.fedorapeople.org/gnome-applet-webilder-0.7-1.fc14.src.rpm

Arch dependency patch it's not good way, but It works. 



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

It looks OK, even though there are still two warnings from rpmlint:

$ rpmlint gnome-applet-webilder-0.7-1.fc14.x86_64.rpm
gnome-applet-webilder.x86_64: E: no-binary

$ rpmlint gnome-applet-webilder-0.7-1.fc14.src.rpm 
gnome-applet-webilder.src: W: %ifarch-applied-patch Patch0: Webilder-lib64.patch
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Will you submit it to rawhide/f15/f14?

I filled an issue request with the upstream with regard to bonobo path:

https://github.com/thesamet/webilder/issues/17

Ok, you issue has been closed by upstream. Please rebuild srpm with new sources and I'll start review.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

(In reply to comment #7)
> It looks OK, even though there are still two warnings from rpmlint:
> 
> $ rpmlint gnome-applet-webilder-0.7-1.fc14.x86_64.rpm
> gnome-applet-webilder.x86_64: E: no-binary
You cannot use noarch because _libdir of gnome-applets is arch-dependency. So, You can ignore this error, 
> $ rpmlint gnome-applet-webilder-0.7-1.fc14.src.rpm 
> gnome-applet-webilder.src: W: %ifarch-applied-patch Patch0:
> Webilder-lib64.patch
If upstream fix libdir error for X86_64 You can remove patch from package and fix this warning.

I'm waiting for upstream to release new version. Until then I think there is no point in packaging git snapshot, i.e. it is better to distribute source of existing release with a patch.

Added NotReady whiteboard

ping?
when upstream plan to release new version?

Nothing yet from upstream. I'll ask for the plans.

I got the answer. New version should probably appear in few weeks.

Ping? Any progress here? Or we can close this review?

Sorry for late response. You can close this review. I don't have time now, and, IMHO, this doesn't work with GNOME3.

Closing per #18