| Summary: | fedpkg tag-request broken | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Krause <chkr> |
| Component: | fedora-packager | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 14 | CC: | belegdol, dcantrell, dennis, kwright, rhbugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-23 22:36:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
I have verified that this is still broken in fedpkg-0.5.7.0-1.fc14.noarch and that this patch works. I can also confirm that the patch works - I was able to edit /usr/bin/fedpkg directly. Fix made upstream, will be in next build. fedora-packager-0.5.8.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.fc15 fedora-packager-0.5.8.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.fc14 fedora-packager-0.5.8.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.fc13 fedora-packager-0.5.8.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.el6 fedora-packager-0.5.8.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.el5 This went stable, but bodhi didn't notice. |
Description of problem: fedpkg tag-request broken, can't create tag requests Version-Release number of selected component (if applicable): fedora-packager-0.5.6.0-1.fc14.noarch How reproducible: 100% Steps to Reproduce: 1. fedpkg tag-request Actual results: fedpkg tag-request Password for chkr: Add a description to your request: Please tag banshee-1.9.5-1.fc15 into dist-f15-override so that banshee-community-extensions can be built against it. Traceback (most recent call last): File "/usr/bin/fedpkg", line 1480, in <module> args.command(args) File "/usr/bin/fedpkg", line 745, in tagrequest ticket = mymodule.new_ticket(user, passasswd, args.desc, args.build) NameError: global name 'passasswd' is not defined Expected results: tag request created Additional info: The problem is caused by a simple typo in /usr/bin/fedpkg: diff --git a/src/fedpkg.py b/src/fedpkg.py index 06dbf17..091bafa 100755 --- a/src/fedpkg.py +++ b/src/fedpkg.py @@ -748,7 +748,7 @@ def tagrequest(args): try: mymodule = pyfedpkg.PackageModule(args.path, args.dist) - ticket = mymodule.new_ticket(user, passasswd, args.desc, args.build) + ticket = mymodule.new_ticket(user, passwd, args.desc, args.build) print('Ticket #%s filed successfully' % ticket) except pyfedpkg.FedpkgError, e: print('Could not request a tag release: %s' % e)