Bug 684686

Summary: Crash on erasure from chroot
Product: [Fedora] Fedora Reporter: Panu Matilainen <pmatilai>
Component: yumAssignee: Packaging Maintenance Team <packaging-team-maint>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 19CC: bochecha, ffesti, goeran, james.antill, maxamillion, pmatilai, psabata, tcallawa, tla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 13:40:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Panu Matilainen 2011-03-14 08:43:00 UTC
Description of problem:
Erasures from chroot aren't always cleanly handled: in some cases it just complains about ts_done not existing, in other cases it crashes.

Version-Release number of selected component (if applicable):
Probably every recent version, but tested with yum-3.2.29-8.fc16.noarch and current yum HEAD.

How reproducible:
Always

Steps to Reproduce:
1. yum --disablerepo="*" --enablerepo="rawhide" --installroot=/home/test/ -y install bash
2. yum --disablerepo="*" --enablerepo="rawhide" --installroot=/home/test/ -y remove bash
  
Actual results:
[...]
Running Transaction
  Erasing    : bash-4.2.7-1.fc16.x86_64                                     1/5 
could not open ts_done file: [Errno 2] No such file or directory: '/home/test/var/lib/yum/transaction-done.2011-03-14.04:34.11'
Non-fatal POSTUN scriptlet failure in rpm package bash
  Erasing    : ncurses-libs-5.8-1.fc16.x86_64                               2/5 
warning: %postun(bash-4.2.7-1.fc16.x86_64) scriptlet failed, exit status 127
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/yum/rpmtrans.py", line 406, in callback
  File "/usr/lib/python2.7/site-packages/yum/rpmtrans.py", line 500, in _unInstStop
  File "/usr/lib/python2.7/site-packages/yum/rpmtrans.py", line 246, in _scriptout
  File "/usr/lib/python2.7/site-packages/yum/history.py", line 863, in log_scriptlet_output
  File "/usr/lib/python2.7/site-packages/yum/sqlutils.py", line 168, in executeSQLQmark
sqlite3.OperationalError: disk I/O error
error: python callback <bound method RPMTransaction.callback of <yum.rpmtrans.RPMTransaction instance at 0x7f39f2d24368>> failed, aborting!

Expected results:
Transaction completes without crashing.

Additional info:
Happened to notice while testing something else. Not considering this particularly critical issue, just filing so it wont go forgotten.

Comment 1 seth vidal 2011-03-14 14:02:52 UTC
is /home/ an nfs mount or other 'odd' filesystem?

b/c this:

sqlite3.OperationalError: disk I/O error

normally means something is WRONG with the mount or WRONG with the disk.

Comment 2 Panu Matilainen 2011-03-14 14:15:00 UTC
/home is just a regular ext4 fs. This is trivially reproducable on any installroot path you throw at it.

Comment 3 seth vidal 2011-03-14 14:18:47 UTC
never seen it before on any of the installroots I've setup, nor on reports from mock usage.

to be fair, mock doesn't erase very much.

Comment 4 Panu Matilainen 2011-03-14 14:23:47 UTC
I know, chroot erasures aren't exactly the most common operation.

FWIW I haven't looked at what exactly happens here, but one possible cause could be chroot occurring in the middle of sqlite open-access-close, it certainly has the potential of showing up as "something is very wrong with the disk" :)

Comment 5 Panu Matilainen 2011-03-15 08:34:34 UTC
AFAICT there's indeed an active connection/cursor to the history db that is opened outside of chroot but erasure callbacks occur inside the chroot and sqlite gets rather unhappy about this.

The other part here is that on an erasure-only transaction, RPMTransaction.ts_done() only ever gets called inside the chroot causing the path to be wrong (ie the "could not open ts_done" errors)

Comment 6 Mathieu Bridon 2012-04-24 09:56:53 UTC
On RHEL 6, I'm not seeing this crash, so that has probably been fixed at some point (I'm running yum-3.2.29-22.el6_2.2).

However, I'm still seeing the "could not open ts_done" errors mentioned by Panu in comment 5.

Same use case: chroot erasure (I use it a lot in the unit tests of a yum frontend I'm maintaining at work).

Comment 7 Fedora End Of Life 2013-04-03 17:35:08 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 8 Fedora End Of Life 2015-01-09 16:36:18 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 9 Fedora End Of Life 2015-02-17 13:40:42 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.