| Summary: | Fix FTBFS on PPC due to missing readq/writeq | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> | ||||
| Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | gansalmon, itamar, jonathan, jwboyer, kernel-maint, kmcmartin, madhu.chinakonda | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | ppc | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-03-30 00:04:13 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Peter Lemenkov
2011-03-15 14:14:06 UTC
Created attachment 484778 [details]
Patch which fixes this issue
Koji scratchbuild for F-15 (ppc & ppc64): http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=166326 (In reply to comment #1) > Created attachment 484778 [details] > Patch which fixes this issue Is this the correct fix (i.e. is this going upstream?) Shouldn't readq be added somewhere in the PPC arch definitions? (In reply to comment #3) > (In reply to comment #1) > > Created attachment 484778 [details] > > Patch which fixes this issue > > Is this the correct fix (i.e. is this going upstream?) Shouldn't readq be added > somewhere in the PPC arch definitions? Hello! Unfortunately after some consideration I must admit that this is not a proper fix. It does mainly based on another one patch, but that is no excuse - to provide ugly patch because there is another ugly patch already applied. I'll try to provide proper fix soon. I think the correct fix is to simply disable the driver on 32-bit. A non-atomic 64-bit read can be a dangerous thing (think about a register whose value may change between reads.) (In reply to comment #5) > I think the correct fix is to simply disable the driver on 32-bit. A non-atomic > 64-bit read can be a dangerous thing (think about a register whose value may > change between reads.) Yes, agreed. Kyle pointed out that the driver now requests firmware flash updates using those functions, and we aren't going to be able to support that on ppc32. My previous "fix" I submitted to work around the build failure won't actually result in a fully working driver on this platform. The likelihood of this functioning on those machines is pretty small at this point anyway. OK, I've disabled this driver in the next build for F-15 and in git master for F-16 and beyond. kernel-2.6.38.2-9.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kernel-2.6.38.2-9.fc15 kernel-2.6.38.2-9.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |