Bug 687291

The patches to add IPv6 support to libvirt virtual networks (Bug 586124) inadvertently introduced a regression in behavior: when a virtual network has no dhcp range or static hosts defined, dnsmasq should still be run, in order to provide DNS services to the guests on the network; after IPv6 support was added, a network with neither dhcp range nor static hosts did *not* get an instance of dnsmasq.

This behavior has already been fixed upstream:

commit 7892edc9cc45e4fb1079b627bda3f571ac27041f
Author: Laine Stump <laine>
Date:   Fri Mar 11 11:47:58 2011 -0500

    network driver: Start dnsmasq even if no dhcp ranges/hosts are specified.
    
    This fixes a regression introduced in commit ad48df, and reported on
    the libvirt-users list:
    
      https://www.redhat.com/archives/libvirt-users/2011-March/msg00018.html
    
    The problem in that commit was that we began searching a list of ip
    address definitions (rather than just having one) to look for a dhcp
    range or static host; when we didn't find any, our pointer (ipdef) was
    left at NULL, and when ipdef was NULL, we returned without starting up
    dnsmasq.
    
    Previously dnsmasq was started even without any dhcp ranges or static
    entries, because it's still useful for DNS services.
    
    Another problem I noticed while investigating was that, if there are
    IPv6 addresses, but no IPv4 addresses of any kind, we would jump out
    at an ever higher level in the call chain.
    
    This patch does the following:
    
    1) networkBuildDnsmasqArgv() = all uses of ipdef are protected from
       NULL dereference. (this patch doesn't change indentation, to make
       review easier. The next patch will change just the
       indentation). ipdef is intended to point to the first IPv4 address
       with DHCP info (or the first IPv4 address if none of them have any
       dhcp info).
    
    2) networkStartDhcpDaemon() = if the loop looking for an ipdef with
       DHCP info comes up empty, we then grab the first IPv4 def from the
       list. Also, instead of returning if there are no IPv4 defs, we just
       return if there are no IP defs at all (either v4 or v6). This way a
       network that is IPv6-only will still get dnsmasq listening for DNS
       queries.
    
    3) in networkStartNetworkDaemon() - we will startup dhcp not just if there
       are any IPv4 addresses, but also if there are any IPv6 addresses.

commit e368e71040de75f4021784f792d96e6674029f45
Author: Laine Stump <laine>
Date:   Fri Mar 11 12:07:09 2011 -0500

    network driver: Fix indentation from previous commit
    
    The previous commit put a large portion of networkBuildDnsmasqArgv
    inside an if { } block. This readjusts the indentation.