Bug 687886

Summary: A fs.sh resource for fileystem type tmpfs fails to start
Product: Red Hat Enterprise Linux 5 Reporter: Shane Bradley <sbradley>
Component: rgmanagerAssignee: Lon Hohberger <lhh>
Status: CLOSED WONTFIX QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7CC: cluster-maint, edamato
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-18 18:07:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
This patch removes tmpfs from /usr/share/cluster/fs.sh none

Description Shane Bradley 2011-03-15 16:27:11 UTC
Description of problem:
The filesystem type tmpfs is included in /usr/share/cluster/fs.sh as a supported filesystem type.
When a filesystem resource is created for a tmpfs filesystem the resource will fail to start.

Version-Release number of selected component (if applicable):
rgmanager-2.0.52-9.el5

How reproducible:
Everytime

Steps to Reproduce:
1. Manually edit cluster.conf to include a tmpfs as a resource in a service
$ emacs /etc/cluster/cluster.conf
<resources>
  <fs device="/dev/vdb1" force_fsck="0" force_unmount="0" fsid="13510" 
      fstype="ext3" mountpoint="/mnt/ext3vol1" name="fsext3" options="rw" self_fence="0"/>
  <fs device="none" fstype="tmpfs" mountpoint="/mnt/tmpfsvol1" name="fstmpfs" options="size=128"/>
</resources>
<service autostart="0" name="ext3mount" recovery="disable">
  <fs ref="fsext3"/>
</service>
<service autostart="0" name="tmpfsmount" recovery="disable">
  <fs ref="fstmpfs"/>
</service>
2. Start the service that contains the tmpfs resource
$ clusvcadm -e tmpfsmount.
  
Actual results:
The tmpfs resource will fail to start.

Expected results:
The tmpfs resource should start succesfully if it is a supported fs type in fs.sh.

Additional info:

Comment 1 Shane Bradley 2011-03-15 16:31:23 UTC
The tmpfs filesystem type should be removed from /usr/share/cluster/fs.sh. A
tmpfs is different from other fs types we support. I believe that tmpfs should
be removed from fs.sh.

Instead of creating a "filesystem" resource for tmpfs, the tmpfs should instead
be created as a "script" resource. The script resource on start would mount the
tmpfs filesystem, on stop would umount the tmpfs, and on status would check to
see if the tmpfs is mounted.

Comment 3 Shane Bradley 2011-03-15 16:32:56 UTC
Created attachment 485549 [details]
This patch removes tmpfs from /usr/share/cluster/fs.sh

Comment 5 Lon Hohberger 2011-03-18 18:07:27 UTC
tmpfs has never really worked; I'm not entirely sure why it's even in fs.sh at all.

This has already been removed upstream.