Bug 687914
| Summary: | oprofile user without $HOME | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Account closed by user <c719711> | ||||||
| Component: | oprofile | Assignee: | William Cohen <wcohen> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | notting, wcohen | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | oprofile-0.9.6-20.fc14 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2011-03-31 18:59:53 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Account closed by user
2011-03-15 17:37:58 UTC
In general, system packages should stay out of the /home space. I see the problem line in oprofile.spec:
useradd -r -g oprofile -d /home/oprofile -r -u 16 -s /sbin/nologin \
-c "Special user account to be used by OProfile" oprofile
What would be the preferred directory to use? Looking at:
https://fedoraproject.org/wiki/PackagingDrafts/UserCreation
So that should be:
useradd -r -g oprofile -d %homedir -r -u 16 -s /sbin/nologin \
-c "Special user account to be used by OProfile" oprofile
Shouldn't there be an entry in the following oprofile?
https://fedoraproject.org/wiki/PackageUserRegistry
Created attachment 485578 [details]
Avoid using /home/oprofile as home for user oprofile
So something like the attached patch to correct the problem?
I'm not seeing where %homedir is defined. Am I missing something? Created attachment 485587 [details]
Remove the %homedir in the patch
The %homedir was from the code snippet on . When testing things out I realize that it %homedir wasn't a predefined macro. This patch corrects that.
The other question I had was the 'test "$1" != 0 || " in the %postun. Are those required?
Yes, they're needed - otherwise it will fire when you're upgrading the package and the old version gets removed. New patch looks good. https://fedoraproject.org/wiki/Packaging:UsersAndGroups has more info. Patch now in the oprofile.spec and rebuilt in oprofile-0.9.6-18, so this should no longer be an issue. oprofile-0.9.6-20.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/oprofile-0.9.6-20.fc13 oprofile-0.9.6-20.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/oprofile-0.9.6-20.fc14 oprofile-0.9.6-20.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/oprofile-0.9.6-20.fc15 oprofile-0.9.6-20.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. oprofile-0.9.6-20.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. oprofile-0.9.6-20.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |