| Summary: | Review Request: dvi2bitmap - convert DVI files to bitmaps | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Mohamed El Morabity <pikachu.2014> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pikachu.2014 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-01 22:31:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jerry James
2011-03-15 22:35:44 UTC
I will review this package. Mohamed, are you having difficulty with the review? Is there something I can do to help? Sorry for not being reactive, I got unfortunately very busy these last days. But I've never forgot this review :). I've seen your patch reports on the SF page of dvi2bitmap. But I'm afraid you won't probably get any answer from the developers, since the project seems dead for 3 years at least :(. Moreover, no other Linux distribution I've checked seems to provide dvi2bitmap, so you'd be probably the only one to maintain this soft. Anyway I won't close this review if you're still willing to maintain dvi2bitmap, even without upstream. The package looks quite good in itself. I've quickly checked the patches, almost all of them look OK for me, except dvi2bitmap-init.patch: could you explain what was the issue fixed by swapping initializations? I am willing to maintain this package, even with a dead upstream. I need it to produce documentation for another package, which is the one I *really* want in Fedora. :-) The only point to swapping the initializations is to make g++ stop issuing warnings about the initializer order not matching the order of the fields in the class declaration. I like warning-free builds, because then I notice if a new warning pops up. That's all. If you object, I'll drop that patch. Ok for the patch :) (In reply to comment #4) > I am willing to maintain this package, even with a dead upstream. I need it to > produce documentation for another package, which is the one I *really* want in > Fedora. :-) Have you considered patching this other soft to use maybe dvipng instead of dvi2bitmap? It's just a suggestion ^^ Hmmmm, I will have to see how hard that is. Give me a day or two to attempt that conversion before we proceed with this review. It's doable. I'll modify the other project to use dvipng (and send the changes upstream) and drop this package. Thanks, Mohamed. Sorry for giving you more work than expected. I'll be glad to review your next package, if you want. |