Bug 688062

Summary:	fish: add luks-open mapped device to tab completion list
Product:	Red Hat Enterprise Linux 6	Reporter:	Jinxin Zheng <jzheng>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	6.1	CC:	leiwang, mshao
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libguestfs-1.7.17-24.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 10:31:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jinxin Zheng 2011-03-16 07:46:56 UTC

Description of problem:
Currently no one tells where the mapped device created by luks-open is. It's completely the user's job to read the manual and take '/dev/mapper/mapname'. Guestfish should help to remember this name.

Version-Release number of selected component (if applicable):
libguestfs-1.7.17-15.el6

How reproducible:
always

Steps to Reproduce:
1.
...
><fs> luks-open /dev/sda1 map1
Enter key or passphrase ("key"): 
><fs> list-devices 
/dev/vda
><fs> list-filesystems 
><fs> mount /dev/[TAB]
/dev/vda   /dev/vda1  

  
Actual results:
We wanted to get the mapped device name from the tab completion, but failed.
We can't either see it from list-devices or list-filesystems.
However, `mount /dev/mapper/map1 / ` works fine.

Comment 1 Richard W.M. Jones 2011-06-10 09:59:33 UTC

Let's try to fix this for 6.2.  Should be very simple.

Comment 2 Richard W.M. Jones 2011-07-12 12:41:41 UTC

Patch posted upstream:

https://www.redhat.com/archives/libguestfs/2011-July/msg00020.html

Comment 3 Richard W.M. Jones 2011-07-13 08:58:36 UTC

Fix included upstream in the following commits:

http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=ce5a8978b54f409de4347f16f7065b063cb47cf1
http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=4d4d3b2498be9dc8ab7e5f16928ac8f1874c2a58

Comment 4 Richard W.M. Jones 2011-08-10 16:01:00 UTC

https://brewweb.devel.redhat.com/taskinfo?taskID=3546057

Comment 6 Jinxin Zheng 2011-08-23 09:21:24 UTC

Reproduced in -1.7.17-19 and verified in -1.7.17-26.

$ guestfish
><fs> sparse test.img 100M
><fs> run
><fs> part-disk /dev/sda mbr
><fs> luks-format /dev/sda1 1
Enter key or passphrase ("key"): 
><fs> luks-open /dev/sda1 luks1
Enter key or passphrase ("key"): 
><fs> mount /dev/[TAB]
/dev/mapper/luks1  /dev/vda           /dev/vda1

(-19 does not have the /dev/mapper/luks1 entry, -26 does.)

Comment 7 errata-xmlrpc 2011-12-06 10:31:30 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1512.html