Bug 688157

- rpmlint
cpupowerutils-devel.x86_64: W: no-dependency-on cpupowerutils/cpupowerutils-libs/libcpupowerutils
cpupowerutils.src: W: invalid-url Source0: cpupowerutils-325b57765dce1aea97c575d64dee91fcf6ee95c5.tar.gz

- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines
- package must be licensed with Fedora approved license OK
- license field must match actual license - license must be GPLv2 (for example files in lib directory)
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build
http://koji.fedoraproject.org/koji/taskinfo?taskID=2919367
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla  OK
- build dependencies must be listed in BuildRequires  ?
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel  OK
- devel package usually require base package ?
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides cpupowerutils-009-0.1.p1.fc14.x86_64.rpm 
cpufreq-utils = 1:009-0.1.p1.fc14
cpufrequtils = 1:009-0.1.p1.fc14
libcpufreq.so.0()(64bit)  
cpupowerutils = 009-0.1.p1.fc14
cpupowerutils(x86-64) = 009-0.1.p1.fc14

rpm -qp --requires cpupowerutils-009-0.1.p1.fc14.x86_64.rpm 
/sbin/ldconfig  
/sbin/ldconfig  
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
libc.so.6(GLIBC_2.3)(64bit)  
libc.so.6(GLIBC_2.3.4)(64bit)  
libc.so.6(GLIBC_2.4)(64bit)  
libcpufreq.so.0()(64bit)  
libpci.so.3()(64bit)  
libpci.so.3(LIBPCI_3.0)(64bit)  
librt.so.1()(64bit)  
librt.so.1(GLIBC_2.2.5)(64bit)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)  

In archive is directory cpupowerutils-cpupowerutils. Is it intentional?

Patch0 should be sent to upstream or have at least bug in our bugzilla.

Marcela,

thank you for the review.

(In reply to comment #1)
> (...)
> - package MUST successfully compile and build
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2919367
> - architecture listed in ExcludeArch MUST have a bug filed in bugzilla  OK
> - build dependencies must be listed in BuildRequires  ?

Fixed by re-including the old 'disable-gsic' patch.

> (...)
> - devel package usually require base package ?

Fixed.

> (...)
> In archive is directory cpupowerutils-cpupowerutils. Is it intentional?

This was a gitorious.org export. I repackaged the sources tarball to look sane, dropping the %setup -n option.

> Patch0 should be sent to upstream or have at least bug in our bugzilla.

This was reported by EL6 QA -- language files should have the same creation times on all architectures. Since Koji might build packages at different times, it's not always the case. This patch forces a certain exact time for them.

Fixed spec and 0.2.p1 SRPM:
http://psabata.fedorapeople.org/packages/cpupowerutils/cpupowerutils.spec
http://psabata.fedorapeople.org/packages/cpupowerutils/cpupowerutils-009-0.2.p1.fc14.src.rpm

Build passed.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2920007

There's problem with license:
- license field must match actual license - license must be GPLv2 (for example
files in lib directory)

(In reply to comment #3)
> Build passed.
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2920007
> 
> There's problem with license:
> - license field must match actual license - license must be GPLv2 (for example
> files in lib directory)

Corrected.
http://psabata.fedorapeople.org/packages/cpupowerutils/cpupowerutils.spec
http://psabata.fedorapeople.org/packages/cpupowerutils/cpupowerutils-009-0.3.p1.fc14.src.rpm

APPROVED

New Package SCM Request
=======================
Package Name: cpupowerutils
Short Description: Tools to determine and set CPU power related settings
Owners: psabata
Branches: f14 f15
InitialCC:

Git done (by process-git-requests).

Imported and built.
Thank you both!