| Summary: | Review Request: libdeltacloud - C API for accessing deltacloud | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Lalancette <clalance> |
| Component: | Package Review | Assignee: | Ian Main <imain> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | urgent | ||
| Version: | rawhide | CC: | fedora-package-review, imain, matt, notting |
| Target Milestone: | --- | Flags: | imain:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-13 17:36:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Chris Lalancette
2011-03-16 15:39:48 UTC
I also ran this through rpmlint: [clalance@localhost libdeltacloud (master)]$ rpmlint libdeltacloud.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [clalance@localhost libdeltacloud (master)]$ rpmlint ~/rpmbuild/SRPMS/libdeltacloud-0.7-1.fc14.src.rpm libdeltacloud.src: W: spelling-error Summary(en_US) deltacloud -> delta cloud, delta-cloud, deltaic libdeltacloud.src: W: spelling-error %description -l en_US deltacloud -> delta cloud, delta-cloud, deltaic 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [clalance@localhost libdeltacloud (master)]$ (the warnings are wrong, since the name of the API that we are targeting is indeed deltacloud) Only thing I see is that:
%attr(0755,root,root) %{_includedir}/libdeltacloud/hardware_profile.h
should be 644, otherwise it looks good.
OK, I've fixed up the permissions on the header file (it was just a typo). I've re-uploaded the spec and SRPM to the same place, same name: SPEC: http://people.redhat.com/clalance/libdeltacloud/rpmreview/libdeltacloud.spec SRPM: http://people.redhat.com/clalance/libdeltacloud/rpmreview/libdeltacloud-0.7-1.fc14.src.rpm Chris Lalancette Looks good. APPROVED I set the fedora-review to +, hopefully that is all I need to do? New Package SCM Request ======================= Package Name: libdeltacloud Short Description: A C API for accessing deltacloud Owners: clalance Branches: f14 f15 InitialCC: Git done (by process-git-requests). |