Bug 688341
Summary: | Fix Coverity code maintainability issues | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Retired] 389 | Reporter: | Nathan Kinder <nkinder> | ||||||||||||||||||
Component: | Directory Server | Assignee: | Nathan Kinder <nkinder> | ||||||||||||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Chandrasekar Kannan <ckannan> | ||||||||||||||||||
Severity: | unspecified | Docs Contact: | |||||||||||||||||||
Priority: | unspecified | ||||||||||||||||||||
Version: | 1.2.8 | CC: | benl, rmeggins | ||||||||||||||||||
Target Milestone: | --- | ||||||||||||||||||||
Target Release: | --- | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Whiteboard: | |||||||||||||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||
Doc Text: | Story Points: | --- | |||||||||||||||||||
Clone Of: | Environment: | ||||||||||||||||||||
Last Closed: | 2011-05-17 14:08:55 UTC | Type: | --- | ||||||||||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||||||||||
Documentation: | --- | CRM: | |||||||||||||||||||
Verified Versions: | Category: | --- | |||||||||||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||
Embargoed: | |||||||||||||||||||||
Bug Depends On: | |||||||||||||||||||||
Bug Blocks: | 690319 | ||||||||||||||||||||
Attachments: |
|
Description
Nathan Kinder
2011-03-16 20:21:11 UTC
Created attachment 485829 [details]
Patch for cov#10709
Created attachment 485851 [details]
Patch for cov#10708
Created attachment 486041 [details]
Patch for cov#10707
Created attachment 486043 [details]
Patch for cov#10706 & 10707
Created attachment 486053 [details]
Patch for cov#10704 & 10705
Created attachment 486057 [details]
Patch for cov#10703
Created attachment 486059 [details]
Patch for cov#10702
Pushed patches to master. Thanks to Noriko for her reviews! Counting objects: 44, done. Delta compression using up to 2 threads. Compressing objects: 100% (36/36), done. Writing objects: 100% (36/36), 3.29 KiB, done. Total 36 (delta 27), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git bd148df..9d5d73c master -> master Created attachment 486862 [details]
Additional patch for cov#10709
A re-run of Coverity uncovered another issue around cov#10709. This fixes the issue.
Pushed additional patch from comment#9 to master. Thanks to Noriko for her review! Counting objects: 11, done. Delta compression using up to 2 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 658 bytes, done. Total 6 (delta 4), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 6ada149..0498723 master -> master Do we want to target any of these for 389 1.2.8? (In reply to comment #11) > Do we want to target any of these for 389 1.2.8? No, I don't think so. None of them look critical. |