Bug 688723

Summary: libvirtd crashes with poorly formatted command
Product: Red Hat Enterprise Linux 6 Reporter: Alex Williamson <alex.williamson>
Component: libvirtAssignee: Osier Yang <jyang>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.1CC: ajia, dallan, dyuan, eblake, jdenemar, jyang, vbian, yoyzhang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-0.8.7-15.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:29:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alex Williamson 2011-03-17 20:08:52 UTC
Description of problem:

$ sudo virsh qemu-monitor-command rhel6vm-libvirt {system_reset}
error: server closed connection: 

$ sudo virsh list
error: unable to connect to '/var/run/libvirt/libvirt-sock', libvirtd may need to be started: Connection refused
error: failed to connect to the hypervisor


Version-Release number of selected component (if applicable):
libvirt-0.8.7-11.el6.x86_64

How reproducible:
1/1

Steps to Reproduce:
1. do a bad json command as in description
2.
3.
  
Actual results:
libvirtd dies

Expected results:
no death

Additional info:

Comment 4 Osier Yang 2011-03-23 15:08:38 UTC
http://www.redhat.com/archives/libvir-list/2011-March/msg01066.html

patch pushed to upstream.

Comment 5 Osier Yang 2011-03-23 15:44:44 UTC
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-March/msg00634.html

patch posted internally, move to POST.

Comment 6 Osier Yang 2011-03-25 08:43:10 UTC
*** Bug 690734 has been marked as a duplicate of this bug. ***

Comment 8 zhanghaiyan 2011-03-30 02:35:37 UTC
Reproduced this bug with older package libvirt-0.8.7-11.el6.x86_64
# for i in {1..10}; do virsh qemu-monitor-command rhel6-qcow2 {system_reset}; done
error: server closed connection: 

error: unable to connect to '/var/run/libvirt/libvirt-sock', libvirtd may need to be started: Connection refused
......
# service libvirtd status
libvirtd dead but pid file exists

Verified this bug PASS with libvirt-0.8.7-15.el6.x86_64
- 2.6.32-125.el6.x86_64
- qemu-kvm-0.12.1.2-2.153.el6.x86_64
# for i in {1..10}; do virsh qemu-monitor-command rhel6-qcow2 {system_reset}; done
error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


error: internal error cannot parse json {system_reset}: lexical error: invalid char in json text.
                                      {system_reset}
                     (right here) ------^


[root@dhcp-65-132 ~]# virsh list
 Id Name                 State
----------------------------------
  7 rhel6-qcow2          running

[root@dhcp-65-132 ~]# service libvirtd status
libvirtd (pid  24069) is running...

Comment 11 errata-xmlrpc 2011-05-19 13:29:14 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0596.html